Skip to content

Commit e20313f

Browse files
authored
remove docker image build (#1376)
* remove docker image build * changelog
1 parent fdd827a commit e20313f

File tree

3 files changed

+2
-99
lines changed

3 files changed

+2
-99
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ jobs:
260260
with:
261261
name: coverage-report-${{ matrix.group }}
262262
path: "~/.local/share/coverage/${{ matrix.group }}.coverage"
263-
retention-days: 1 # Automatically deletes after 1 day
263+
retention-days: 1 # Automatically deletes after 1 day
264264

265265
- name: Check if git is dirty
266266
run: |
@@ -308,7 +308,6 @@ jobs:
308308
MULTIPROCESSING_DEFAULT_START_METHOD: spawn
309309
run: ./test.sh --splits 3 --group ${{ matrix.group }} --splitting-algorithm least_duration
310310

311-
312311
coverage_report:
313312
needs: [webknossos_linux]
314313
if: success()
@@ -344,81 +343,6 @@ jobs:
344343
- name: Cleanup temporary files
345344
run: rm -rf ~/coverage-files
346345

347-
webknossos_cli_docker:
348-
needs:
349-
- cluster_tools_slurm
350-
- cluster_tools_multiprocessing
351-
- cluster_tools_kubernetes
352-
- cluster_tools_dask
353-
- webknossos_linux
354-
- webknossos_windows
355-
if: |
356-
always() &&
357-
!contains(needs.*.result, 'failure') &&
358-
!contains(needs.*.result, 'cancelled') &&
359-
!github.event.pull_request.head.repo.fork
360-
runs-on: ubuntu-latest
361-
steps:
362-
- uses: actions/checkout@v3
363-
- name: Install uv
364-
uses: astral-sh/setup-uv@v3
365-
- name: Write version file
366-
run: |
367-
pushd webknossos
368-
369-
PKG_VERSION="$(uvx dunamai from git)"
370-
echo "__version__ = '$PKG_VERSION'" > ./webknossos/version.py
371-
sed -i 's/version = "0.0.0"/version = "'"${PKG_VERSION}"'"/g' pyproject.toml
372-
373-
popd
374-
375-
- name: Build docker image
376-
run: docker build -t scalableminds/webknossos-cli:$GITHUB_SHA -f webknossos/Dockerfile .
377-
378-
- name: Smoke test docker
379-
run: |
380-
docker run --rm \
381-
-v$(pwd)/webknossos/testdata:/webknossos/testdata \
382-
scalableminds/webknossos-cli:$GITHUB_SHA \
383-
webknossos convert \
384-
--jobs 2 \
385-
--voxel-size 1,1,1 \
386-
testdata/tiff testoutput/tiff
387-
388-
- name: Login to docker
389-
env:
390-
DOCKER_USER: ${{ secrets.DOCKER_USER }}
391-
DOCKER_PASS: ${{ secrets.DOCKER_PASS }}
392-
run: |
393-
echo $DOCKER_PASS | docker login -u $DOCKER_USER --password-stdin
394-
395-
- name: Push docker images
396-
run: |
397-
docker push scalableminds/webknossos-cli:$GITHUB_SHA
398-
399-
- name: Push docker images (for tag)
400-
if: github.ref_type == 'tag'
401-
run: |
402-
CI_TAG=$(git describe --tags)
403-
docker tag \
404-
scalableminds/webknossos-cli:$GITHUB_SHA \
405-
scalableminds/webknossos-cli:$CI_TAG
406-
docker push scalableminds/webknossos-cli:$CI_TAG
407-
docker tag \
408-
scalableminds/webknossos-cli:$GITHUB_SHA \
409-
scalableminds/webknossos-cli:latest
410-
docker push scalableminds/webknossos-cli:latest
411-
412-
- name: Push docker images (for branch)
413-
if: github.ref_type == 'branch'
414-
run: |
415-
CI_BRANCH=${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}
416-
NORMALIZED_CI_BRANCH=${CI_BRANCH//[\/-]/_}
417-
docker tag \
418-
scalableminds/webknossos-cli:$GITHUB_SHA \
419-
scalableminds/webknossos-cli:$NORMALIZED_CI_BRANCH
420-
docker push scalableminds/webknossos-cli:$NORMALIZED_CI_BRANCH
421-
422346
docs:
423347
needs:
424348
- cluster_tools_slurm
@@ -525,7 +449,6 @@ jobs:
525449
- cluster_tools_slurm
526450
- webknossos_linux
527451
- webknossos_windows
528-
- webknossos_cli_docker
529452
- docs
530453
- pypi_and_gh_release
531454
if: always()

webknossos/Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
1313
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v2.5.0...HEAD)
1414

1515
### Breaking Changes
16+
- Removed Docker image `scalableminds/webknossos-cli` build. It will not be released further. [#1376](https://github.com/scalableminds/webknossos-libs/pull/1376)
1617

1718
### Added
1819

webknossos/Dockerfile

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)