Skip to content

Commit 0b031be

Browse files
fm3coderabbitai[bot]hotzenklotz
authored
Fix bug in dataset upload where the datastore uri was discarded (#9436)
This broke dataset upload if the datastore uri wasn’t equal to the wk uri. ### Steps to test: - Follow steps in https://github.com/scalableminds/webknossos/wiki/Set-up-a-standalone-datastore-locally - Upload a dataset via UI - Should work. ------ - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [x] Removed dev-only changes like prints and application.conf edits - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Tom Herold <tom.herold@scalableminds.com>
1 parent fdd0b19 commit 0b031be

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

frontend/javascripts/libs/resumable-upload.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ const helpers = {
248248
url.searchParams.append(key, value);
249249
});
250250

251-
return url.pathname + url.search;
251+
return url.toString();
252252
},
253253
};
254254

unreleased_changes/9436.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- Fixed a bug in dataset upload where the datastore URI was discarded and requests were always sent to the WEBKNOSSOS base URI.

0 commit comments

Comments
 (0)