You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR avoids using new object identities in certain accessors. This
also fixes that the "Create Annotation" button was constantly rerendered
on mouse move.
### URL of deployed dev instance (used for testing):
- https://___.webknossos.xyz
### Steps to test:
- I applied this local diff:
```
diff --git i/frontend/javascripts/viewer/view/action_bar_view.tsx w/frontend/javascripts/viewer/view/action_bar_view.tsx
index 70c3e06..4406989a26 100644
--- i/frontend/javascripts/viewer/view/action_bar_view.tsx
+++ w/frontend/javascripts/viewer/view/action_bar_view.tsx
@@ -305,7 +305,7 @@ class ActionBarView extends React.PureComponent<Props, State> {
key="ai-job-button"
onClick={() => Store.dispatch(setAIJobModalStateAction(APIJobType.INFER_NEURONS))}
style={{ marginLeft: 12, pointerEvents: "auto" }}
- disabled={disabled}
+ // disabled={disabled}
title={tooltipText}
icon={<i className="fas fa-magic" />}
>
@@ -370,9 +370,7 @@ class ActionBarView extends React.PureComponent<Props, State> {
<DatasetPositionAndRotationView />
<AdditionalCoordinatesInputView />
<ModesView />
- {getIsAIAnalysisEnabled() && isAdminOrDatasetManager
- ? this.renderStartAIJobButton(shouldDisableAIJobButton, tooltip)
- : null}
+ {this.renderStartAIJobButton(shouldDisableAIJobButton, tooltip)}
{isViewMode ? this.renderStartTracingButton() : null}
{constants.MODES_PLANE.indexOf(viewMode) > -1 ? <ToolbarView /> : null}
</div>
```
and opened the AI modal (without no worker setup). prior to the PR, the
infinite requests to the credit cost calculation could be seen. with
this PR, it's fixed.
### Issues:
- fixes https://scm.slack.com/archives/C5AKLAV0B/p1759755474212069
------
(Please delete unneeded items, merge only when none are left open)
- [x] Added changelog entry (create a `$PR_NUMBER.md` file in
`unreleased_changes` or use `./tools/create-changelog-entry.py`)
- [ ] Added migration guide entry if applicable (edit the same file as
for the changelog)
- [ ] Updated [documentation](../blob/master/docs) if applicable
- [ ] Adapted [wk-libs python
client](https://github.com/scalableminds/webknossos-libs/tree/master/webknossos/webknossos/client)
if relevant API parts change
- [ ] Removed dev-only changes like prints and application.conf edits
- [ ] Considered [common edge
cases](../blob/master/.github/common_edge_cases.md)
- [ ] Needs datastore update after deployment
---------
Co-authored-by: MichaelBuessemeyer <[email protected]>
0 commit comments