Fix labels for new-dataset slack notifications (#9000)

Currently everything is logged to slack as "upload without conversion".
That’s not quite right.

------
While not technically true just yet, it seems that this belongs here


![](https://media2.giphy.com/media/v1.Y2lkPTc5MGI3NjExODhyb2NxbXdicnE4d2s0bWZ0bWlqMWYyZnNrdmU4MnByYnNxNm9sNyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/tPKoWQJk3cEbC/giphy.gif)

Related: #3000

------
- [x] Removed dev-only changes like prints and application.conf edits
- [x] Considered [common edge
cases](../blob/master/.github/common_edge_cases.md)

Author: fm3

app/controllers/DatasetController.scala

@@ -239,7 +239,7 @@ class DatasetController @Inject()(userService: UserService,
                                            user,
                                            needsConversion = false,
                                            datasetSizeBytes = 0,
-                                           viaAddRoute = false)
+                                           addVariantLabel = "via explore+add")
       } yield Ok(Json.obj("newDatasetId" -> dataset._id))
     }
 
@@ -663,7 +663,7 @@ class DatasetController @Inject()(userService: UserService,
                                            request.identity,
                                            needsConversion = false,
                                            datasetSizeBytes = 0,
-                                           viaAddRoute = false)
+                                           addVariantLabel = "via uploadToPaths/publish")
       } yield Ok
     }
 

app/controllers/WKRemoteDataStoreController.scala

@@ -136,7 +136,7 @@ class WKRemoteDataStoreController @Inject()(
                                              user,
                                              request.body.needsConversion,
                                              request.body.datasetSizeBytes,
-                                             viaAddRoute = false)
+                                             addVariantLabel = "upload without conversion")
           dataSourceWithLinkedLayersOpt <- Fox.runOptional(request.body.dataSourceOpt) {
             implicit val ctx: DBAccessContext = AuthorizedAccessContext(user)
             layerToLinkService.addLayersToLinkToDataSource(_, request.body.layersToLink)

app/models/dataset/DatasetService.scala

@@ -549,22 +549,21 @@ class DatasetService @Inject()(organizationDAO: OrganizationDAO,
                       user: User,
                       needsConversion: Boolean,
                       datasetSizeBytes: Long,
-                      viaAddRoute: Boolean): Fox[Unit] =
+                      addVariantLabel: String): Fox[Unit] =
     for {
-      _ <- Fox.runIf(!needsConversion)(logDatasetUploadToSlack(user, dataset._id, viaAddRoute))
+      _ <- Fox.runIf(!needsConversion)(logDatasetUploadToSlack(user, dataset._id, addVariantLabel))
       dataStore <- dataStoreDAO.findOneByName(dataset._dataStore)(GlobalAccessContext)
       _ = analyticsService.track(UploadDatasetEvent(user, dataset, dataStore, datasetSizeBytes))
       _ = if (!needsConversion) mailchimpClient.tagUser(user, MailchimpTag.HasUploadedOwnDataset)
     } yield ()
 
-  private def logDatasetUploadToSlack(user: User, datasetId: ObjectId, viaAddRoute: Boolean): Fox[Unit] =
+  private def logDatasetUploadToSlack(user: User, datasetId: ObjectId, addVariantLabel: String): Fox[Unit] =
     for {
       organization <- organizationDAO.findOne(user._organization)(GlobalAccessContext)
       multiUser <- multiUserDAO.findOne(user._multiUser)(GlobalAccessContext)
       resultLink = s"${conf.Http.uri}/datasets/$datasetId"
-      addLabel = if (viaAddRoute) "(via explore+add)" else "(upload without conversion)"
       superUserLabel = if (multiUser.isSuperUser) " (for superuser)" else ""
-      _ = slackNotificationService.info(s"Dataset added $addLabel$superUserLabel",
+      _ = slackNotificationService.info(s"Dataset added ($addVariantLabel)$superUserLabel",
                                         s"For organization: ${organization.name}. <$resultLink|Result>")
     } yield ()