Add s3 upload config to standalone datastore config (#8986)

This was unfortunately not asserted because the children reference was
missing.

### Steps to test:
- CI

------
- [x] Needs datastore update after deployment

Author: fm3

conf/messages

@@ -117,7 +117,7 @@ dataset.upload.invalidLinkedLayers=Could not link all requested layers
 dataset.upload.couldNotLoadUnfinishedUploads=Could not load unfinished uploads of user.
 dataset.upload.noFiles=Tried to finish upload with no files. May be a retry of a failed finish request, see previous errors.
 dataset.upload.storageExceeded=Cannot upload dataset because the storage quota of the organization is exceeded.
-dataset.upload.finishFailed=Failed to finalize dataset upload.
+dataset.upload.finishFailed=Failed to finalize upload for dataset {0}.
 dataset.upload.moveToTarget.failed=Failed to move uploaded dataset to target directory.
 dataset.upload.moreBytesThanReserved=The uploaded dataset contains more bytes than originally reserved. Please make sure to reserve the correct amount of bytes.
 dataset.upload.creation.failed=Failed to create dataset.

webknossos-datastore/app/com/scalableminds/webknossos/datastore/DataStoreConfig.scala

@@ -66,7 +66,7 @@ class DataStoreConfig @Inject()(configuration: Configuration) extends ConfigRead
       val objectKeyPrefix: String = get[String]("datastore.s3Upload.objectKeyPrefix")
       val credentialName: String = get[String]("datastore.s3Upload.credentialName")
     }
-    val children = List(WebKnossos, WatchFileSystem, Cache, AdHocMesh, Redis, AgglomerateSkeleton)
+    val children = List(WebKnossos, WatchFileSystem, Cache, AdHocMesh, Redis, AgglomerateSkeleton, S3Upload)
   }
 
   object SlackNotifications {

webknossos-datastore/app/com/scalableminds/webknossos/datastore/controllers/DataSourceController.scala

@@ -36,6 +36,7 @@ import com.scalableminds.webknossos.datastore.services.mapping.AgglomerateServic
 import com.scalableminds.webknossos.datastore.slacknotification.DSSlackNotificationService
 import play.api.data.Form
 import play.api.data.Forms.{longNumber, nonEmptyText, number, tuple}
+import play.api.i18n.Messages
 import play.api.libs.Files
 import play.api.libs.json.{Json, OFormat}
 import play.api.mvc.{Action, AnyContent, MultipartFormData, PlayBodyParsers}
@@ -192,7 +193,8 @@ class DataSourceController @Inject()(
             .getDatasetIdByUploadId(request.body.uploadId) ?~> "dataset.upload.validation.failed"
           response <- accessTokenService.validateAccessFromTokenContext(UserAccessRequest.writeDataset(datasetId)) {
             for {
-              datasetId <- uploadService.finishUpload(request.body) ?~> "dataset.upload.finishFailed"
+              _ <- uploadService.finishUpload(request.body, datasetId) ?~> Messages("dataset.upload.finishFailed",
+                                                                                    datasetId)
             } yield Ok(Json.obj("newDatasetId" -> datasetId))
           }
         } yield response

webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/uploading/UploadService.scala

@@ -349,12 +349,11 @@ class UploadService @Inject()(dataSourceService: DataSourceService,
       }
     } yield ()
 
-  def finishUpload(uploadInformation: UploadInformation)(implicit tc: TokenContext): Fox[ObjectId] = {
+  def finishUpload(uploadInformation: UploadInformation, datasetId: ObjectId)(implicit tc: TokenContext): Fox[Unit] = {
     val uploadId = uploadInformation.uploadId
 
     for {
       dataSourceId <- getDataSourceIdByUploadId(uploadId)
-      datasetId <- getDatasetIdByUploadId(uploadId)
       _ = logger.info(s"Finishing ${uploadFullName(uploadId, datasetId, dataSourceId)}...")
       linkedLayerIdentifiers <- getObjectFromRedis[LinkedLayerIdentifiers](redisKeyForLinkedLayerIdentifier(uploadId))
       needsConversion = uploadInformation.needsConversion.getOrElse(false)
@@ -389,7 +388,7 @@ class UploadService @Inject()(dataSourceService: DataSourceService,
           linkedLayerIdentifiers.layersToLink.getOrElse(List.empty)
         )
       ) ?~> "reportUpload.failed"
-    } yield datasetId
+    } yield ()
   }
 
   private def deleteFilesNotReferencedInDataSource(unpackedDir: Path, dataSource: UsableDataSource): Fox[Unit] =

webknossos-datastore/conf/standalone-datastore.conf

@@ -89,6 +89,12 @@ datastore {
     # The credentials are selected by uri prefix, so different s3 uri styles may need duplicated credential entries.
     credentials = []
   }
+  s3Upload {
+    enabled = false
+    # Use the name of a credential in the dataVaults section here to use it for uploads.
+    credentialName = "s3://example/uri/prefix"
+    objectKeyPrefix = "webknossos-uploads"
+  }
 }
 
 slackNotifications {