Fix a number of cyclic dependency imports (#9204)

This PR fixes a number of cyclic dependency imports. All fixes were
simply done by moving code around.

1. `04_configure_new_dataset.tsx` --> `toast.tsx`
- the method `Toast.guardedWithErrorToast` was only used in
`04_confiure_new_dataset` and nowwhere else. just moved it.
2. `flycam_accessor` --> `flycam_reducer`
- `rotateOnAxis` is the only import from `flycam_reducer` into
`flycam_accessor`. The other way around, the reducer already imported a
bunch of stuff from the accessor. So I moved this utility to the
accesor.
3. `task_create_bulk_view.ts` --> `task_create_from_view.ts`
    - move shared methods in a new file `task_create_utils.ts`
4. `skeletontracing_accessor.ts` --> `tree_hierarchy_view_helpers.ts`
--> `tree_hierarchy_view`
- moved `mapGroups` and related method `mapGroupsWithRoot` to
`tree_hierarchy_view_helpers` to break the cycle. One could argue, that
these methods should have been there in the first place, since the all
relate to tree hierarchies.

### URL of deployed dev instance (used for testing):
- https://___.webknossos.xyz

### Steps to test:
- CI should be enough


### Issues:
- Contributes to #9243

------
(Please delete unneeded items, merge only when none are left open)
- [ ] Added changelog entry (create a `$PR_NUMBER.md` file in
`unreleased_changes` or use `./tools/create-changelog-entry.py`)
- [ ] Added migration guide entry if applicable (edit the same file as
for the changelog)
- [ ] Updated [documentation](../blob/master/docs) if applicable
- [ ] Adapted [wk-libs python
client](https://github.com/scalableminds/webknossos-libs/tree/master/webknossos/webknossos/client)
if relevant API parts change
- [ ] Removed dev-only changes like prints and application.conf edits
- [ ] Considered [common edge
cases](../blob/master/.github/common_edge_cases.md)
- [ ] Needs datastore update after deployment

Author: hotzenklotz

frontend/javascripts/admin/api/tasks.ts

@@ -3,7 +3,7 @@ import type {
   NewNmlTask,
   NewTask,
   TaskCreationResponseContainer,
-} from "admin/task/task_create_bulk_view";
+} from "admin/task/task_create_utils";
 import type { QueryObject } from "admin/task/task_search_form";
 import type { RequestOptions } from "libs/request";
 import Request from "libs/request";

frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx

@@ -19,11 +19,12 @@ import {
 } from "antd";
 import { FormItemWithInfo } from "dashboard/dataset/helper_components";
 import FolderSelection from "dashboard/folders/folder_selection";
+import ErrorHandling from "libs/error_handling";
 import { estimateAffineMatrix4x4 } from "libs/estimate_affine";
 import { formatNumber } from "libs/format_utils";
 import { useEffectOnlyOnce } from "libs/react_hooks";
 import { useWkSelector } from "libs/react_hooks";
-import Toast, { guardedWithErrorToast } from "libs/toast";
+import Toast from "libs/toast";
 import { isUserAdminOrDatasetManager } from "libs/utils";
 import uniqBy from "lodash-es/uniqBy";
 import messages from "messages";
@@ -39,6 +40,16 @@ import type { WizardComponentProps } from "./common";
 
 const FormItem = Form.Item;
 
+async function guardedWithErrorToast(fn: () => Promise<any>) {
+  try {
+    await fn();
+  } catch (error) {
+    Toast.error("An unexpected error occurred. Please check the console for details");
+    console.error(error);
+    ErrorHandling.notify(error as Error);
+  }
+}
+
 export function ConfigureNewDataset(props: WizardComponentProps) {
   const formRef = React.useRef<FormInstance<any>>(null);
 

frontend/javascripts/admin/task/task_create_bulk_view.tsx

@@ -7,72 +7,17 @@ import isString from "lodash-es/isString";
 import uniq from "lodash-es/uniq";
 import Messages from "messages";
 import { useState } from "react";
-import type { APITask } from "types/api_types";
 import type { Vector3 } from "viewer/constants";
-import type { BoundingBoxObject } from "viewer/store";
+import {
+  NUM_TASKS_PER_BATCH,
+  type NewTask,
+  type TaskCreationResponse,
+  normalizeFileEvent,
+} from "./task_create_utils";
 
 const FormItem = Form.Item;
 const { TextArea } = Input;
 
-export const NUM_TASKS_PER_BATCH = 100;
-export type NewTask = {
-  readonly boundingBox: BoundingBoxObject | null | undefined;
-  readonly datasetId: string;
-  readonly editPosition: Vector3;
-  readonly editRotation: Vector3;
-  readonly neededExperience: {
-    readonly domain: string;
-    readonly value: number;
-  };
-  readonly projectName: string;
-  readonly scriptId: string | null | undefined;
-  readonly pendingInstances: number;
-  readonly taskTypeId: string;
-  readonly csvFile?: File;
-  readonly nmlFiles?: File[];
-  readonly baseAnnotation?:
-    | {
-        baseId: string;
-      }
-    | null
-    | undefined;
-};
-
-export type NewNmlTask = Pick<
-  NewTask,
-  | "taskTypeId"
-  | "neededExperience"
-  | "pendingInstances"
-  | "projectName"
-  | "scriptId"
-  | "boundingBox"
->;
-
-export type TaskCreationResponse = {
-  status: number;
-  success?: APITask;
-  error?: string;
-};
-
-export type TaskCreationResponseContainer = {
-  tasks: TaskCreationResponse[];
-  warnings: string[];
-};
-
-export function normalizeFileEvent(
-  event:
-    | File[]
-    | {
-        fileList: File[];
-      },
-) {
-  if (Array.isArray(event)) {
-    return event;
-  }
-
-  return event?.fileList;
-}
-
 function TaskCreateBulkView() {
   const { modal } = App.useApp();
 

frontend/javascripts/admin/task/task_create_form_view.tsx

@@ -7,13 +7,6 @@ import {
   getTaskTypes,
   getUnversionedAnnotationInformation,
 } from "admin/rest_api";
-import type {
-  NewNmlTask,
-  NewTask,
-  TaskCreationResponse,
-  TaskCreationResponseContainer,
-} from "admin/task/task_create_bulk_view";
-import { NUM_TASKS_PER_BATCH, normalizeFileEvent } from "admin/task/task_create_bulk_view";
 import {
   Alert,
   App,
@@ -53,6 +46,13 @@ import { useNavigate, useParams } from "react-router-dom";
 import type { APIDataset, APIProject, APIScript, APITask, APITaskType } from "types/api_types";
 import type { Vector3, Vector6 } from "viewer/constants";
 import type { BoundingBoxObject } from "viewer/store";
+import type {
+  NewNmlTask,
+  NewTask,
+  TaskCreationResponse,
+  TaskCreationResponseContainer,
+} from "./task_create_utils";
+import { NUM_TASKS_PER_BATCH, normalizeFileEvent } from "./task_create_utils";
 
 const FormItem = Form.Item;
 const RadioGroup = Radio.Group;

frontend/javascripts/admin/task/task_create_utils.tsx

@@ -0,0 +1,62 @@
+import type { APITask } from "types/api_types";
+import type { BoundingBoxObject } from "types/bounding_box";
+import type { Vector3 } from "viewer/constants";
+
+export const NUM_TASKS_PER_BATCH = 100;
+export type NewTask = {
+  readonly boundingBox: BoundingBoxObject | null | undefined;
+  readonly datasetId: string;
+  readonly editPosition: Vector3;
+  readonly editRotation: Vector3;
+  readonly neededExperience: {
+    readonly domain: string;
+    readonly value: number;
+  };
+  readonly projectName: string;
+  readonly scriptId: string | null | undefined;
+  readonly pendingInstances: number;
+  readonly taskTypeId: string;
+  readonly csvFile?: File;
+  readonly nmlFiles?: File[];
+  readonly baseAnnotation?:
+    | {
+        baseId: string;
+      }
+    | null
+    | undefined;
+};
+
+export type NewNmlTask = Pick<
+  NewTask,
+  | "taskTypeId"
+  | "neededExperience"
+  | "pendingInstances"
+  | "projectName"
+  | "scriptId"
+  | "boundingBox"
+>;
+
+export type TaskCreationResponse = {
+  status: number;
+  success?: APITask;
+  error?: string;
+};
+
+export type TaskCreationResponseContainer = {
+  tasks: TaskCreationResponse[];
+  warnings: string[];
+};
+
+export function normalizeFileEvent(
+  event:
+    | File[]
+    | {
+        fileList: File[];
+      },
+) {
+  if (Array.isArray(event)) {
+    return event;
+  }
+
+  return event?.fileList;
+}

frontend/javascripts/libs/toast.tsx

@@ -38,19 +38,6 @@ type ToastParams = {
   details?: string;
 };
 
-export async function guardedWithErrorToast(fn: () => Promise<any>) {
-  try {
-    await fn();
-  } catch (error) {
-    import("libs/error_handling").then((_ErrorHandling) => {
-      const ErrorHandling = _ErrorHandling.default;
-      Toast.error("An unexpected error occurred. Please check the console for details");
-      console.error(error);
-      ErrorHandling.notify(error as Error);
-    });
-  }
-}
-
 const Toast = {
   // The notificationAPI is designed to be a singleton spawned by the ToastContextMountRoot
   // mounted in the GlobalThemeProvider.

frontend/javascripts/viewer/api/api_latest.ts

@@ -75,7 +75,6 @@ import {
   getTreeAndNode,
   getTreeAndNodeOrNull,
   getTreeGroupsMap,
-  mapGroups,
 } from "viewer/model/accessors/skeletontracing_accessor";
 import { AnnotationTool, type AnnotationToolId } from "viewer/model/accessors/tool_accessor";
 import {
@@ -188,6 +187,7 @@ import {
   MISSING_GROUP_ID,
   callDeep,
   createGroupToSegmentsMap,
+  mapGroups,
   moveGroupsHelper,
 } from "viewer/view/right-border-tabs/trees_tab/tree_hierarchy_view_helpers";
 

frontend/javascripts/viewer/model/accessors/flycam_accessor.ts

@@ -49,7 +49,6 @@ import {
   invertTransform,
   transformPointUnscaled,
 } from "../helpers/transformation_helpers";
-import { rotateOnAxis } from "../reducers/flycam_reducer";
 import { reuseInstanceOnEquality } from "./accessor_helpers";
 
 export const ZOOM_STEP_INTERVAL = 1.1;
@@ -745,3 +744,6 @@ function _getActiveMagInfo(state: WebknossosState) {
 }
 
 export const getActiveMagInfo = reuseInstanceOnEquality(_getActiveMagInfo);
+export function rotateOnAxis(currentMatrix: Matrix4x4, angle: number, axis: Vector3): Matrix4x4 {
+  return M4x4.rotate(angle, axis, currentMatrix, []);
+}

frontend/javascripts/viewer/model/accessors/skeletontracing_accessor.ts

@@ -15,10 +15,7 @@ import {
   TreeMap,
 } from "viewer/model/types/tree_types";
 import type { NumberLike, SkeletonTracing, StoreAnnotation, WebknossosState } from "viewer/store";
-import {
-  MISSING_GROUP_ID,
-  findGroup,
-} from "viewer/view/right-border-tabs/trees_tab/tree_hierarchy_view_helpers";
+import { findGroup } from "viewer/view/right-border-tabs/trees_tab/tree_hierarchy_view_helpers";
 import { max } from "../helpers/iterator_utils";
 import { invertTransform, transformPointUnscaled } from "../helpers/transformation_helpers";
 import {
@@ -329,30 +326,3 @@ export function* mapGroupsToGenerator<R>(
     }
   }
 }
-
-function mapGroupAndChildrenHelper(group: TreeGroup, fn: (g: TreeGroup) => TreeGroup): TreeGroup {
-  const newChildren = mapGroups(group.children, fn);
-  return fn({ ...group, children: newChildren });
-}
-
-export function mapGroups(groups: TreeGroup[], fn: (g: TreeGroup) => TreeGroup): TreeGroup[] {
-  return groups.map((group) => mapGroupAndChildrenHelper(group, fn));
-}
-
-export function mapGroupsWithRoot(
-  groups: TreeGroup[],
-  fn: (g: TreeGroup) => TreeGroup,
-): TreeGroup[] {
-  // Add the virtual root group so that the map function can also mutate
-  // the high-level elements (e.g., filtering elements in the first level).
-  return mapGroups(
-    [
-      {
-        name: "Root",
-        groupId: MISSING_GROUP_ID,
-        children: groups,
-      },
-    ],
-    fn,
-  )[0].children; // Read the root group's children again
-}

frontend/javascripts/viewer/model/reducers/flycam_reducer.ts

@@ -11,6 +11,7 @@ import {
   getRotationInDegrees,
   getRotationInRadian,
   getValidZoomRangeForUser,
+  rotateOnAxis,
 } from "viewer/model/accessors/flycam_accessor";
 import type { Action } from "viewer/model/actions/actions";
 import Dimensions from "viewer/model/dimensions";
@@ -39,10 +40,6 @@ function cloneMatrix(m: Matrix4x4): Matrix4x4 {
   ];
 }
 
-export function rotateOnAxis(currentMatrix: Matrix4x4, angle: number, axis: Vector3): Matrix4x4 {
-  return M4x4.rotate(angle, axis, currentMatrix, []);
-}
-
 // Avoid creating new THREE object for some actions.
 const flycamRotationEuler = new Euler();
 const flycamRotationMatrix = new Matrix4();