Skip to content

Commit a1b4616

Browse files
Fix ordering of periodically polled update actions (#8919)
Due to #8757 the sorting of the polled update actions was wrong. #8757 introduced a new parameter to the `getUpdateActionLog` function while forgetting to change the usage of `getUpdateActionLog` in `save_saga.tsx`. Not the polling mechanism does loads the updates not truncated and in correct order. The bug was noticable due to update only being applied version after version as the sorting of the polled update actions was wrong thus leading to the oldest update action / the one with the lowest version number to be applied last. This means that the locally stored annotation version was always only incremented by one for each poll. Making thing buggy. ### URL of deployed dev instance (used for testing): - https://___.webknossos.xyz ### Steps to test: - Open an annotation as user A (e.g. turn on othersMayEdit) - Open the same annotation as user B - Do multiple annotation actions with visible changes as user A. E.g. brush multiple cells. Then save - Observe user B. All actions should be applied in one go and not one version every 10 seconds. ### Issues: - fixes self noticed bug during working on #8723 ------ (Please delete unneeded items, merge only when none are left open) - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`)
1 parent 13f3f2a commit a1b4616

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

frontend/javascripts/viewer/model/sagas/saving/save_saga.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ function* watchForSaveConflicts(): Saga<void> {
9898
annotationId,
9999
versionOnClient + 1,
100100
undefined,
101+
false,
101102
true,
102103
);
103104

unreleased_changes/8919.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- Fix periodic polling of missing updates when another user edits an annotation.

0 commit comments

Comments
 (0)