Skip to content

Commit abcdb07

Browse files
authored
Add new camera perspectives for animations (#8909)
This PR adds two new camera perspectives for animation jobs: - static camera looking at XY plane (top-down view on the stack) - static, isometric camera looking a the corner between XY, XZ, YZ plane ### Steps to test: - CI should be enough for the frontend, backend changes - Otherwise see worker PR ### TODOs: - [ ] Merge related [worker PR first](scalableminds/voxelytics#4279) # DO NOT MERGE BEFORE UPDATING AND DEPLOYING WORKER FIRST ### Issues: - None ------ (Please delete unneeded items, merge only when none are left open) - [ ] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [ ] Added migration guide entry if applicable (edit the same file as for the changelog) - [x] Updated [documentation](../blob/master/docs) if applicable - [ ] Adapted [wk-libs python client](https://github.com/scalableminds/webknossos-libs/tree/master/webknossos/webknossos/client) if relevant API parts change - [ ] Removed dev-only changes like prints and application.conf edits - [ ] Considered [common edge cases](../blob/master/.github/common_edge_cases.md) - [ ] Needs datastore update after deployment
1 parent b525db4 commit abcdb07

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed

app/controllers/JobController.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ object MovieResolutionSetting extends ExtendedEnumeration {
3131
}
3232

3333
object CameraPositionSetting extends ExtendedEnumeration {
34-
val MOVING, STATIC_XZ, STATIC_YZ = Value
34+
val MOVING, STATIC_ISOMETRIC, STATIC_XY, STATIC_XZ, STATIC_YZ = Value
3535
}
3636

3737
case class AnimationJobOptions(

docs/automation/animations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Creating an animation is easy:
1212
2. Optionally, load some [3D meshes](../meshes/index.md) for any segments that you wish to highlight.
1313
3. For larger datasets, use the bounding box tool to create a bounding box around your area of interest. Smaller datasets can be used in their entirety.
1414
4. From the `Menu` dropdown in navbar at the top of the screen, select "Create Animation".
15-
5. Configure the animation options as desired, i.e. camera movement or resolution.
15+
5. Configure the animation options as desired, i.e. camera movement and positioning or video resolution.
1616
6. Click the `Start animation` button to launch the animation creation.
1717

1818

frontend/javascripts/types/api_types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1280,6 +1280,8 @@ export type FolderUpdater = {
12801280

12811281
export enum CAMERA_POSITIONS {
12821282
MOVING = "MOVING",
1283+
STATIC_ISOMETRIC = "STATIC_ISOMETRIC",
1284+
STATIC_XY = "STATIC_XY",
12831285
STATIC_XZ = "STATIC_XZ",
12841286
STATIC_YZ = "STATIC_YZ",
12851287
}

frontend/javascripts/viewer/view/action-bar/create_animation_modal.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,12 +406,18 @@ function CreateAnimationModal(props: Props) {
406406
<Radio.Button value={CAMERA_POSITIONS.MOVING}>
407407
Camera circling around the dataset
408408
</Radio.Button>
409+
<Radio.Button value={CAMERA_POSITIONS.STATIC_XY}>
410+
Static camera looking at XY-viewport{" "}
411+
</Radio.Button>
409412
<Radio.Button value={CAMERA_POSITIONS.STATIC_XZ}>
410413
Static camera looking at XZ-viewport{" "}
411414
</Radio.Button>
412415
<Radio.Button value={CAMERA_POSITIONS.STATIC_YZ}>
413416
Static camera looking at YZ-viewport{" "}
414417
</Radio.Button>
418+
<Radio.Button value={CAMERA_POSITIONS.STATIC_ISOMETRIC}>
419+
Static camera with an isometric perspective looking at all 3 viewports{" "}
420+
</Radio.Button>
415421
</Space>
416422
</Radio.Group>
417423
</Col>

unreleased_changes/8909.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Added
2+
- Added new camera positioning option for animations.

0 commit comments

Comments
 (0)