You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR avoids requesting out-of-bounds ad hoc mesh chunks in an
infinite loop.
### URL of deployed dev instance (used for testing):
- https://fixadhocmeshinfiniteloading.webknossos.xyz
### Steps to test:
- Best to test locally with a dataset without segment index
- please not, that ad hoc meshing is bug for transformed datasets. See
#8913.
- checkout 3fc42bd to have a
visualization of what happens on the master
- View a dataset without a segment index.
- Load some segments ad hoc mesh. Watch boxes appear -> infinitely mesh
requests e.g. going more and more out of bounds.
- Note: The bounds of the boxes are not correct but still helpful to see
at what coordinates mesh chunk requests are sent.
- check out 67f2060 and do the same
again after reload
- now no boxes outside of the segmentation layer should be requested and
the request should terminate rather quickly
### TODOs:
- [x] remove debug bboxes code
### Issues:
- fixes reported here:
https://scm.slack.com/archives/C02H5T8Q08P/p1757417432537409?thread_ts=1757338710.530969&cid=C02H5T8Q08P
------
(Please delete unneeded items, merge only when none are left open)
- [x] Added changelog entry (create a `$PR_NUMBER.md` file in
`unreleased_changes` or use `./tools/create-changelog-entry.py`)
---------
Co-authored-by: Daniel <[email protected]>
0 commit comments