Skip to content

Commit e35c367

Browse files
fix skeleton tracing proto mocking in skeleton proofreading tests
1 parent cba1273 commit e35c367

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

frontend/javascripts/test/fixtures/skeletontracing_server_objects.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const TRACING_ID = "skeletonTracingId-47e37793-d0be-4240-a371-87ce68561a13";
1111
export const tracing: ServerSkeletonTracing = {
1212
typ: AnnotationLayerEnum.Skeleton,
1313
id: TRACING_ID,
14-
datasetName: "ROI2017_wkw",
1514
trees: [
1615
{
1716
treeId: 2,

frontend/javascripts/test/fixtures/tasktracing_server_objects.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { ViewModeValues } from "viewer/constants";
99
const TRACING_ID = "skeletonTracingId-e90133de-b2db-4912-8261-8b6f84f7edab";
1010
export const tracing: ServerSkeletonTracing = {
1111
typ: "Skeleton",
12-
datasetName: "ROI2017_wkw",
1312
trees: [
1413
{
1514
nodes: [

frontend/javascripts/test/sagas/proofreading/proofreading_skeleton_test_utils.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,12 @@ export function createSkeletonTracingFromAdjacency(
111111
metadata: [],
112112
};
113113

114-
const tracing: ServerSkeletonTracing = {
114+
type ServerSkeletonTracingProtoCompatible = ServerSkeletonTracing & {
115+
datasetName: string; // Still part of the proto but unused. Needed to make
116+
// custom proto parsing & mocking work in proofreading skeleton tests.
117+
};
118+
119+
const tracing: ServerSkeletonTracingProtoCompatible = {
115120
datasetName: "is-ignored-anyway",
116121
id: tracingId,
117122
userBoundingBoxes: [],

frontend/javascripts/types/api_types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,6 @@ export type SkeletonUserState = {
953953
export type ServerSkeletonTracing = ServerTracingBase & {
954954
// The following property is added when fetching the
955955
// tracing from the back-end (by `getTracingForAnnotationType`)
956-
datasetName: string; // still part of the proto file, might be outdated. Do not rely on correct values.
957956
typ: "Skeleton"; // This is done to simplify the selection for the type.
958957
activeNodeId?: number; // only use as a fallback if userStates is empty
959958
boundingBox?: BoundingBoxProto;

0 commit comments

Comments
 (0)