fix mypy in test_api.py and synchronous.py

Author: brokkoli71

src/zarr/api/synchronous.py

@@ -8,6 +8,7 @@
 import zarr.core.array
 from zarr._compat import _deprecate_positional_args
 from zarr.core.array import Array, AsyncArray
+from zarr.core.buffer.core import NDArrayLike
 from zarr.core.group import Group
 from zarr.core.sync import sync
 
@@ -216,7 +217,7 @@ def open_consolidated(*args: Any, use_consolidated: Literal[True] = True, **kwar
 
 def save(
     store: StoreLike,
-    *args: NDArrayOrScalarLike,
+    *args: NDArrayLike,
     zarr_version: ZarrFormat | None = None,  # deprecated
     zarr_format: ZarrFormat | None = None,
     path: str | None = None,
@@ -247,7 +248,7 @@ def save(
 @_deprecate_positional_args
 def save_array(
     store: StoreLike,
-    arr: NDArrayOrScalarLike,
+    arr: NDArrayLike,
     *,
     zarr_version: ZarrFormat | None = None,  # deprecated
     zarr_format: ZarrFormat | None = None,
@@ -290,12 +291,12 @@ def save_array(
 
 def save_group(
     store: StoreLike,
-    *args: NDArrayOrScalarLike,
+    *args: NDArrayLike,
     zarr_version: ZarrFormat | None = None,  # deprecated
     zarr_format: ZarrFormat | None = None,
     path: str | None = None,
     storage_options: dict[str, Any] | None = None,
-    **kwargs: NDArrayOrScalarLike,
+    **kwargs: NDArrayLike,
 ) -> None:
     """Save several NumPy arrays to the local file system.
 

tests/test_api.py

@@ -237,7 +237,7 @@ def test_open_with_mode_r(tmp_path: pathlib.Path) -> None:
     assert isinstance(z2, Array)
     assert z2.fill_value == 1
     assert isinstance(z2[:], NDArrayLike)
-    assert (z2[:] == 1).all()
+    assert (z2[:] == 1).all() # type: ignore [operator]
     with pytest.raises(ValueError):
         z2[:] = 3
 
@@ -249,7 +249,8 @@ def test_open_with_mode_r_plus(tmp_path: pathlib.Path) -> None:
     zarr.ones(store=tmp_path, shape=(3, 3))
     z2 = zarr.open(store=tmp_path, mode="r+")
     assert isinstance(z2, Array)
-    assert (z2[:] == 1).all()
+    assert isinstance(z2[:], NDArrayLike)
+    assert (z2[:] == 1).all() # type: ignore [operator]
     z2[:] = 3
 
 
@@ -265,7 +266,8 @@ async def test_open_with_mode_a(tmp_path: pathlib.Path) -> None:
     arr[...] = 1
     z2 = zarr.open(store=tmp_path, mode="a")
     assert isinstance(z2, Array)
-    assert (z2[:] == 1).all()
+    assert isinstance(z2[:], NDArrayLike)
+    assert (z2[:] == 1).all() # type: ignore [operator]
     z2[:] = 3
 
 
@@ -277,7 +279,8 @@ def test_open_with_mode_w(tmp_path: pathlib.Path) -> None:
     arr[...] = 3
     z2 = zarr.open(store=tmp_path, mode="w", shape=(3, 3))
     assert isinstance(z2, Array)
-    assert not (z2[:] == 3).all()
+    assert isinstance(z2[:], NDArrayLike)
+    assert (z2[:] == 3).all() # type: ignore [operator]
     z2[:] = 3