improve test

Author: brokkoli71

src/zarr/api/asynchronous.py

@@ -27,6 +27,7 @@
 from zarr.core.group import AsyncGroup, ConsolidatedMetadata, GroupMetadata
 from zarr.core.metadata import ArrayMetadataDict, ArrayV2Metadata, ArrayV3Metadata
 from zarr.core.metadata.v2 import _default_filters_and_compressor
+from zarr.core.sync import sync
 from zarr.errors import NodeTypeValidationError
 from zarr.storage import (
     StoreLike,
@@ -535,7 +536,7 @@ async def tree(grp: AsyncGroup, expand: bool | None = None, level: int | None =
 
 
 async def array(
-    data: npt.ArrayLike, **kwargs: Any
+    data: npt.ArrayLike | Array, **kwargs: Any
 ) -> AsyncArray[ArrayV2Metadata] | AsyncArray[ArrayV3Metadata]:
     """Create an array filled with `data`.
 
@@ -553,11 +554,17 @@ async def array(
     """
 
     if isinstance(data, Array):
-        chunks = kwargs.pop("chunks", None) or data.chunks
-        new_array = await create(shape=data.shape, chunks=chunks, dtype=data.dtype, **kwargs)
+        # fill missing arguments with metadata of data Array
+        kwargs.setdefault("dtype", data.dtype)
+        kwargs.setdefault("attributes", data.attrs)
+        kwargs.setdefault("chunks", data.chunks)
+        kwargs.setdefault("fill_value", data.fill_value)
+
+        new_array = await create(data.shape, **kwargs)
 
         async def _copy_chunk(chunk_coords: ChunkCoords) -> None:
-            await new_array.setitem(chunk_coords, await data._async_array.getitem(chunk_coords))
+            arr = await data._async_array.getitem(chunk_coords)
+            await new_array.setitem(chunk_coords, arr)
 
         # Stream data from the source array to the new array
         await concurrent_map(

tests/test_array.py

@@ -10,6 +10,8 @@
 import numpy as np
 import pytest
 from numcodecs import Zstd
+from numpy import dtype
+from numpy.ma.testutils import assert_array_equal
 
 import zarr.api.asynchronous
 from zarr import Array, AsyncArray, Group
@@ -892,21 +894,30 @@ async def test_scalar_array() -> None:
 
 
 async def test_creation_from_other_zarr(tmpdir):
-    src = zarr.zeros(
-        (2000, 20000), chunks=(1000, 1000), dtype="uint8", store=LocalStore(str(tmpdir))
-    )
-    src[:] = 1
-    for _i in range(10):
-        start_time = time.time()
-        c = zarr.array(src, store=MemoryStore())
-        end_time = time.time()
-        print(f"Time fast: {end_time - start_time} seconds")
-
-        start_time = time.time()
-        b = zarr.zeros(src.shape, chunks=src.chunks, store=MemoryStore())
-        b[:] = src[:]
-        end_time = time.time()
-        print(f"Time slow: {end_time - start_time} seconds")
-
-    assert b[123, 123] == 1
-    assert c[123, 123] == 1
+    src_fill_value = 2
+    src_dtype = np.dtype("uint8")
+    src_attributes = {}
+    src_chunks = (2, 2)
+
+    src = zarr.create((10, 10), chunks=src_chunks, dtype=src_dtype, store=LocalStore(str(tmpdir)), fill_value = src_fill_value, attributes=src_attributes)
+    src[:] = np.arange(100).reshape((10,10))
+
+    result = zarr.array(src, store=MemoryStore())
+    assert_array_equal(result[:], src[:])
+    assert result.fill_value == src_fill_value
+    assert result.dtype==src_dtype
+    assert result.attrs.asdict() == src_attributes
+    assert result.chunks == src_chunks
+
+    new_fill_value = 3
+    new_dtype = np.dtype("uint16")
+    new_attributes = {"foo":"bar"}
+    new_chunks = (5, 10)
+
+    result2 = zarr.array(src, store=MemoryStore(), chunks=new_chunks, dtype=new_dtype, fill_value = new_fill_value, attributes=new_attributes)
+
+    assert_array_equal(result2[:], src[:])
+    assert result2.fill_value == new_fill_value
+    assert result2.dtype == new_dtype
+    assert result2.attrs == new_attributes
+    assert result2.chunks == new_chunks