fix mypy in test_array.py

Author: brokkoli71

tests/test_api.py

@@ -237,7 +237,7 @@ def test_open_with_mode_r(tmp_path: pathlib.Path) -> None:
     assert isinstance(z2, Array)
     assert z2.fill_value == 1
     assert isinstance(z2[:], NDArrayLike)
-    assert (z2[:] == 1).all() # type: ignore [union-attr]
+    assert (z2[:] == 1).all()  # type: ignore [union-attr]
     with pytest.raises(ValueError):
         z2[:] = 3
 
@@ -250,7 +250,7 @@ def test_open_with_mode_r_plus(tmp_path: pathlib.Path) -> None:
     z2 = zarr.open(store=tmp_path, mode="r+")
     assert isinstance(z2, Array)
     assert isinstance(z2[:], NDArrayLike)
-    assert (z2[:] == 1).all() # type: ignore [union-attr]
+    assert (z2[:] == 1).all()  # type: ignore [union-attr]
     z2[:] = 3
 
 
@@ -267,7 +267,7 @@ async def test_open_with_mode_a(tmp_path: pathlib.Path) -> None:
     z2 = zarr.open(store=tmp_path, mode="a")
     assert isinstance(z2, Array)
     assert isinstance(z2[:], NDArrayLike)
-    assert (z2[:] == 1).all() # type: ignore [union-attr]
+    assert (z2[:] == 1).all()  # type: ignore [union-attr]
     z2[:] = 3
 
 
@@ -280,7 +280,7 @@ def test_open_with_mode_w(tmp_path: pathlib.Path) -> None:
     z2 = zarr.open(store=tmp_path, mode="w", shape=(3, 3))
     assert isinstance(z2, Array)
     assert isinstance(z2[:], NDArrayLike)
-    assert (z2[:] == 3).all() # type: ignore [union-attr]
+    assert (z2[:] == 3).all()  # type: ignore [union-attr]
     z2[:] = 3
 
 

tests/test_array.py

@@ -38,7 +38,6 @@
     create_array,
 )
 from zarr.core.buffer import default_buffer_prototype
-from zarr.core.buffer.core import NDArrayLike
 from zarr.core.buffer.cpu import NDBuffer
 from zarr.core.chunk_grids import _auto_partition
 from zarr.core.common import JSON, MemoryOrder, ZarrFormat
@@ -656,10 +655,9 @@ def test_resize_1d(store: MemoryStore, zarr_format: ZarrFormat) -> None:
     a = np.arange(105, dtype="i4")
     z[:] = a
     assert (105,) == z.shape
-    assert hasattr(z[:], "shape") and hasattr(z[:], "dtype")
-    assert (105,) == z[:].shape
+    assert hasattr(z[:], "shape") and (105,) == z[:].shape
     assert np.dtype("i4") == z.dtype
-    assert np.dtype("i4") == z[:].dtype
+    assert hasattr(z[:], "dtype") and np.dtype("i4") == z[:].dtype
     assert (10,) == z.chunks
     np.testing.assert_array_equal(a, z[:])
 

tests/test_buffer.py

@@ -65,10 +65,8 @@ async def test_async_array_prototype() -> None:
         prototype=my_prototype,
     )
     got = await a.getitem(selection=(slice(0, 9), slice(0, 9)), prototype=my_prototype)
-    # ignoring a mypy error here that TestNDArrayLike doesn't meet the NDArrayLike protocol
-    # The test passes, so it clearly does.
-    assert isinstance(got, TestNDArrayLike)  # type: ignore[unreachable]
-    assert np.array_equal(expect, got)  # type: ignore[unreachable]
+    assert isinstance(got, TestNDArrayLike)
+    assert np.array_equal(expect, got)
 
 
 @gpu_test