Parse chunk shape to check for float values (zarr-developers#2535)

* Test that shapes and chunk shapes containing floats raise a TypeError

* Parse chunk shape

* Move check for floats from create to normalize_chunks

---------

Co-authored-by: Joe Hamman <[email protected]>

Author: faymanns

src/zarr/core/chunk_grids.py

@@ -138,6 +138,9 @@ def normalize_chunks(chunks: Any, shape: tuple[int, ...], typesize: int) -> tupl
             s if c == -1 or c is None else int(c) for s, c in zip(shape, chunks, strict=False)
         )
 
+    if not all(isinstance(c, numbers.Integral) for c in chunks):
+        raise TypeError("non integer value in chunks")
+
     return tuple(int(c) for c in chunks)
 
 

tests/test_api.py

@@ -47,6 +47,14 @@ def test_create_array(memory_store: Store) -> None:
     assert z.shape == (400,)
     assert z.chunks == (40,)
 
+    # create array with float shape
+    with pytest.raises(TypeError):
+        z = create(shape=(400.5, 100), store=store, overwrite=True)
+
+    # create array with float chunk shape
+    with pytest.raises(TypeError):
+        z = create(shape=(400, 100), chunks=(16, 16.5), store=store, overwrite=True)
+
 
 @pytest.mark.parametrize("path", ["foo", "/", "/foo", "///foo/bar"])
 @pytest.mark.parametrize("node_type", ["array", "group"])