[Bug] Date format is wrong in Commit Activity

[adpi2]

Current behavior

Expected Behavior

It should print correct dates: from Feb 2024 to Jan 2025

Extra comments

No response

Search terms

No response

[arnavsharma990]

lemme solve it

[adpi2]

lemme solve it

Feel free to solve it, that would be helpful. Thank you in advance.

[rorygraves]

A few debugging points discovered:

The issue is the generated chart html is wrong:

<canvas id="commit-activity" data-commit-activity-count="4,3,6,6,11,6,7,4,7,11,9,8,1,5,8,3,0,5,1,3,12,11,21,20,12,9,7,2,4,3,9,5,5,4,1,0,1,6,3,4,7,2,8,8,6,6,3,6,5,14,4,0" data-commit-activity-starting-day="1722124" width="320" height="160" style="display: block; box-sizing: border-box; height: 160px; width: 320px;"></canvas>

The data-commit-activity-starting-day is being rendered in seconds (not ms) -
1722124 = Tuesday, 20 January 1970 22:22:04
Whereas:
1722124000 is Saturday, 27 July 2024 23:46:40

Commit 4ec112c (Aug 2, 2022) appears to have a fix:

• Before: Used LocalDateTime.ofEpochSecond() and LocalDate.ofEpochDay()
• After: Added Instant.ofEpochSecond(startingDay.toLong) and .toEpochMilli.toDouble

but maybe there is something else missing (seems unlikely a merged commit from 2022 has not been deployed).
Need to get the code running to get further and test.

[arnavsharma990]

Thanks @rorygraves , your note about the timestamp unit was spot on.

I reproduced the issue and confirmed it was a mismatch between the server sending seconds (or a small integer) and the client expecting milliseconds.

I've opened a PR (linked above) that standardizes both the project.scala.html template and the Sparkline.scala frontend to consistently use milliseconds (toEpochMilli).

[kavyakapoor420]

hi @adpi2 can i work in this issue ? if it is still open ,