RemoveUnused.params on Scala 3 Next

scala/scala3#20894

Author: bjaglin

docs/rules/RemoveUnused.md

@@ -84,13 +84,11 @@ object Main {
 }
 ```
 
-On Scala 3, `-Wunused:unsafe-warn-patvars` is required.
-
 On Scala 2.13.15+, canonical patterns (vars with the same names as the
 attributes) do not trigger unused warnings, so the input above will not
 be rewritten. See https://github.com/scala/bug/issues/13035.
 
-### Remove unused function parameters (Scala 2 only)
+### Remove unused function parameters
 
 ```scala
 // before
@@ -103,6 +101,8 @@ object Main {
 }
 ```
 
+On Scala 3, this is only supported for 3.7.0+.
+
 ## Formatting
 
 > This rule does a best-effort at preserving original formatting. In some cases,
@@ -176,8 +176,7 @@ $ scala3 -W
           - nowarn,
           - all,
           - imports :
-            Warn if an import selector is not referenced.
-            NOTE : overrided by -Wunused:strict-no-implicit-warn,
+            Warn if an import selector is not referenced.,
           - privates :
             Warn if a private member is unused,
           - locals :
@@ -188,13 +187,13 @@ $ scala3 -W
             Warn if an implicit parameter is unused,
           - params :
             Enable -Wunused:explicits,implicits,
+          - patvars :
+            Warn if a variable bound in a pattern is unused,
           - linted :
             Enable -Wunused:imports,privates,locals,implicits,
           - strict-no-implicit-warn :
             Same as -Wunused:import, only for imports of explicit named members.
-        NOTE : This overrides -Wunused:imports and NOT set by -Wunused:all,
+            NOTE : This overrides -Wunused:imports and NOT set by -Wunused:all,
           - unsafe-warn-patvars :
-            (UNSAFE) Warn if a variable bound in a pattern is unused.
-            This warning can generate false positive, as warning cannot be
-            suppressed yet.
+            Deprecated alias for `patvars`
 ```

scalafix-rules/src/main/scala/scalafix/internal/rule/RemoveUnused.scala

@@ -96,7 +96,10 @@ class RemoveUnused(config: RemoveUnusedConfig)
         isUnusedPattern += diagnostic.position
       } else if (
         config.params &&
-        (msg.startsWith("parameter") && msg.endsWith("is never used"))
+        (
+          msg.startsWith("parameter") && msg.endsWith("is never used") ||
+            msg == "unused explicit parameter"
+        )
       ) {
         isUnusedParam += diagnostic.position
       }
@@ -189,7 +192,7 @@ class RemoveUnused(config: RemoveUnusedConfig)
         case Term.Function(params, _) =>
           params.collect {
             case param @ Term.Param(_, name, _, _)
-                if isUnusedParam(param.pos) =>
+                if isUnusedParam(param.pos) || isUnusedParam(name.pos) =>
               Patch.replaceTree(name, "_")
           }.asPatch
       }.asPatch

scalafix-rules/src/main/scala/scalafix/internal/rule/RemoveUnusedConfig.scala

@@ -14,7 +14,7 @@ case class RemoveUnusedConfig(
     locals: Boolean = true,
     @Description("Remove unused pattern match variables")
     patternvars: Boolean = true,
-    @Description("Remove unused function parameters (Scala 2 only)")
+    @Description("Remove unused function parameters")
     params: Boolean = true
 )
 

scalafix-tests/input/src/main/scala-2/test/removeUnused/RemoveUnusedParams.scala

@@ -3,8 +3,6 @@ rule = RemoveUnused
  */
 package test.removeUnused
 
-// Not available as of Scala 3.4.1
-// https://github.com/scalacenter/scalafix/issues/1937
 object UnusedParams {
   val f: String => Unit = unused => println("f")
   val ff = (unused: String) => println("f")

scalafix-tests/input/src/main/scala-3next/test/removeUnused/RemoveUnusedParams.scala

@@ -0,0 +1,12 @@
+/*
+rule = RemoveUnused
+ */
+package test.removeUnused
+
+object UnusedParams {
+  val f: String => Unit = unused => println("f")
+  val ff = (unused: String) => println("f")
+  val fs = (used: String, unused: Long) => println(used)
+  def g(x: String => Unit): Unit = ???
+  g{implicit string => println("g")}
+}

scalafix-tests/output/src/main/scala-2/test/removeUnused/RemoveUnusedParams.scala

@@ -1,7 +1,5 @@
 package test.removeUnused
 
-// Not available as of Scala 3.4.1
-// https://github.com/scalacenter/scalafix/issues/1937
 object UnusedParams {
   val f: String => Unit = _ => println("f")
   val ff = (_: String) => println("f")

scalafix-tests/output/src/main/scala-3next/test/removeUnused/RemoveUnusedParams.scala

@@ -0,0 +1,9 @@
+package test.removeUnused
+
+object UnusedParams {
+  val f: String => Unit = _ => println("f")
+  val ff = (_: String) => println("f")
+  val fs = (used: String, _: Long) => println(used)
+  def g(x: String => Unit): Unit = ???
+  g{implicit string => println("g")}
+}