fix: display build errors to users during reload (#1222)

Author: warcholjakub

sbt-runner/src/main/scala/org/scastie/sbt/OutputExtractor.scala

@@ -46,6 +46,8 @@ class OutputExtractor(getScalaJsContent: () => Option[String],
 
     val isScalaJs = inputs.target.targetType == ScalaTargetType.JS
 
+    val isSbtError = output.line.startsWith("[error]") && isReloading
+
     val userOutput =
       if (problems.toList.flatten.isEmpty
           && instrumentations.toList.flatten.isEmpty
@@ -55,6 +57,8 @@ class OutputExtractor(getScalaJsContent: () => Option[String],
           && !isReloading
           && consoleOutput.isEmpty)
         Some(output)
+      else if (isSbtError)
+        Some(output)
       else None
 
     val (scalaJsContent, scalaJsSourceMapContent) =
@@ -64,9 +68,7 @@ class OutputExtractor(getScalaJsContent: () => Option[String],
         (None, None)
       }
 
-    val isSbtError = output.line.startsWith("[error]") && isReloading
-
-    val isReallyDone = (isDone && !isReloading) || isSbtError
+    val isReallyDone = isDone && !isReloading
 
     val sbtProcessOutput =
       consoleOutput match {

sbt-runner/src/main/scala/org/scastie/sbt/SbtProcess.scala

@@ -236,10 +236,11 @@ class SbtProcess(runTimeout: FiniteDuration,
       sendProgress(sbtRun, progress)
 
       if (progress.isSbtError) {
+        sbtRun.timeoutEvent.foreach(_.cancel())
+        val finalProgress = progress.copy(isDone = true)
+        sendProgress(sbtRun, finalProgress)
         throw new Exception("sbt error: " + output.line)
-      }
-
-      if (isPrompt(output.line)) {
+      } else if (isPrompt(output.line)) {
         gotoRunning(sbtRun)
       } else {
         stay()