Skip to content

Commit 013cb2b

Browse files
committed
Merge branch 'master' into release
2 parents 9077cd7 + 186dfb3 commit 013cb2b

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

.gitattributes

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
# Set the default line separator behavior, in case people don't have core.autocrlf set.
2-
* text=auto
2+
# [[https://stackoverflow.com/a/42135910]]
3+
* text=auto eol=lf

ReadMe.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ ScalaFX Extras
22
==============
33

44
[![Build Status](https://travis-ci.org/scalafx/scalafx-extras.svg?branch=master)](https://travis-ci.org/scalafx/scalafx-extras)
5-
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.scalafx/scalafx-extras_2.12/badge.svg)](https://maven-badges.herokuapp.com/maven-central/org.scalafx/scalafx-extras_2.12)
6-
[![Scaladoc](http://javadoc-badge.appspot.com/org.scalafx/scalafx-extras_2.12.svg?label=scaladoc)](http://javadoc-badge.appspot.com/org.scalafx/scalafx-extras_2.12)
5+
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.scalafx/scalafx-extras_2.13/badge.svg)](https://maven-badges.herokuapp.com/maven-central/org.scalafx/scalafx-extras_2.13)
6+
[![Scaladoc](http://javadoc-badge.appspot.com/org.scalafx/scalafx-extras_2.13.svg?label=scaladoc)](http://javadoc-badge.appspot.com/org.scalafx/scalafx-extras_2.13)
77

88
ScalaFX Extras are additions to ScalaFX that simplify creation of User interfaces.
99
In contrast to ScalaFX core, the Extras do not have direct corresponding concepts in JavaFX.

build.sbt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import scala.xml.{Node => XmlNode, NodeSeq => XmlNodeSeq, _}
1111
// JAR_BUILT_BY - Name to be added to Jar metadata field "Built-By" (defaults to System.getProperty("user.name")
1212
//
1313

14-
val projectVersion = "0.3.3"
14+
val projectVersion = "0.3.3.1-SNAPSHOT"
1515
val versionTagDir = if (projectVersion.endsWith("SNAPSHOT")) "master" else "v." + projectVersion
16-
val _scalaVersions = Seq("2.13.1", "2.12.10")
16+
val _scalaVersions = Seq("2.13.1", "2.12.11")
1717
val _scalaVersion = _scalaVersions.head
1818
val _scalaFXVersion = "12.0.2"
1919

@@ -115,7 +115,7 @@ lazy val scalaFXExtrasSettings = Seq(
115115
"org.scala-lang" % "scala-reflect" % scalaVersion.value,
116116
"org.scalafx" %% "scalafx" % "12.0.2-R18",
117117
"org.scalafx" %% "scalafxml-core-sfx8" % "0.5",
118-
"org.scalatest" %% "scalatest" % "3.1.0" % "test"
118+
"org.scalatest" %% "scalatest" % "3.1.1" % "test"
119119
) ++ JavaFXModuleLibsProvided,
120120
// Use `pomPostProcess` to remove dependencies marked as "provided" from publishing in POM
121121
// This is to avoid dependency on wrong OS version JavaFX libraries

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@
2424
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
2525
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2626
#
27-
sbt.version=1.3.8
27+
sbt.version=1.3.10
2828

project/sbt-sonatype.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
// [https://github.com/xerial/sbt-sonatype]
2-
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.8.1")
2+
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.2")
33
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "2.0.1")

scalafx-extras/src/main/scala/org/scalafx/extras/mvcfx/MVCfx.scala

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2011-2018, ScalaFX Project
2+
* Copyright (c) 2011-2020, ScalaFX Project
33
* All rights reserved.
44
*
55
* Redistribution and use in source and binary forms, with or without
@@ -67,8 +67,12 @@ abstract class MVCfx(fxmlFilePath: String) {
6767
def model: ModelFX
6868

6969
/** Top level UI node for this component. */
70-
val view: Parent = createFXMLView()
71-
model.parent.value = view
70+
lazy val view: Parent = {
71+
val _view = createFXMLView()
72+
// Delay assigment till `view` is accessed first time
73+
model.parent.value = _view
74+
_view
75+
}
7276

7377
/** Create a stage containing this component. The model is initialized on a separate thread. */
7478
def createStage(title: String): Stage = {

0 commit comments

Comments
 (0)