Skip to content

Commit c5ce990

Browse files
committed
Merge branch 'master' into release
2 parents ea502fc + 590a393 commit c5ce990

File tree

5 files changed

+24
-7
lines changed

5 files changed

+24
-7
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,4 @@ project/target
2525
*.sc
2626
.externalToolBuilders/
2727
/_local_/
28+
/.bsp/

.jvmopts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@
22
-Xms512M
33
-Xmx1536M
44
-Xss2M
5-
-XX:+CMSClassUnloadingEnabled

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import scala.xml.{Node => XmlNode, NodeSeq => XmlNodeSeq, _}
1010
// JAR_BUILT_BY - Name to be added to Jar metadata field "Built-By" (defaults to System.getProperty("user.name")
1111
//
1212

13-
val projectVersion = "0.3.5"
13+
val projectVersion = "0.3.5.1-SNAPSHOT"
1414
val versionTagDir = if (projectVersion.endsWith("SNAPSHOT")) "master" else "v." + projectVersion
1515
val _scalaVersions = Seq("2.13.4", "2.12.12")
1616
val _scalaVersion = _scalaVersions.head

notes/0.3.6.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
### ScalaFX-Extras Release v.0.3.6
2+
3+
Enhancement:
4+
5+
* Update to ScalaFX 15.0.1-R21
6+
7+
Bug fix:
8+
9+
* [Issue #10][10] `Wait` cursor is not set reliably by the BusyWorker
10+
11+
To post questions please use [ScalaFX Users Group][scalafx-users] or [StackOverflow ScalaFX][scalafx-overflow]
12+
13+
[scalafx-users]: https://groups.google.com/forum/#!forum/scalafx-users
14+
15+
[scalafx-overflow]: https://stackoverflow.com/questions/tagged/scalafx
16+
17+
[10]: https://github.com/scalafx/scalafx-extras/issues/10
18+

scalafx-extras/src/main/scala/org/scalafx/extras/BusyWorker.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2011-2020, ScalaFX Project
2+
* Copyright (c) 2011-2021, ScalaFX Project
33
* All rights reserved.
44
*
55
* Redistribution and use in source and binary forms, with or without
@@ -27,8 +27,6 @@
2727

2828
package org.scalafx.extras
2929

30-
import java.util.concurrent.Future
31-
3230
import javafx.{scene => jfxs}
3331
import org.scalafx.extras.BusyWorker.SimpleTask
3432
import scalafx.Includes._
@@ -38,6 +36,7 @@ import scalafx.concurrent.Worker
3836
import scalafx.scene.{Cursor, Node}
3937
import scalafx.stage.Window
4038

39+
import java.util.concurrent.Future
4140
import scala.language.implicitConversions
4241
import scala.util.control.NonFatal
4342

@@ -432,7 +431,7 @@ class BusyWorker private(val title: String,
432431
nodesToDisable.foreach { node =>
433432
node.disable = false
434433
// Use Option to guard against null values
435-
Option(node.scene()).map(_.root()).foreach(_.cursor = Cursor.Default)
434+
Option(node.scene()).foreach(_.cursor = Cursor.Default)
436435
}
437436
busy() = false
438437
_busyWorkloadName = "[None]"
@@ -449,7 +448,7 @@ class BusyWorker private(val title: String,
449448
nodesToDisable.foreach { node =>
450449
node.disable = true
451450
// Use Option to guard against null values
452-
Option(node.scene()).map(_.root()).foreach(_.cursor = Cursor.Wait)
451+
Option(node.scene()).foreach(_.cursor = Cursor.Wait)
453452
}
454453
}
455454

0 commit comments

Comments
 (0)