Skip to content

Commit 639e132

Browse files
Apply suggestions from code review
Co-authored-by: Hiroyuki Yamada <[email protected]>
1 parent 5cca44c commit 639e132

File tree

1 file changed

+7
-7
lines changed
  • lib/src/main/java/com/scalar/admin/kubernetes

1 file changed

+7
-7
lines changed

lib/src/main/java/com/scalar/admin/kubernetes/Pauser.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -242,12 +242,12 @@ PauserException buildException(
242242
@Nullable StatusUnmatchedException statusUnmatchedException) {
243243
PauserException pauserException = null;
244244

245-
// Unpause issue is the most critical because it might cause system down.
245+
// Treat the unpause failure as most critical because it might cause system unavailability.
246246
if (unpauseFailedException != null) {
247247
pauserException = unpauseFailedException;
248248
}
249249

250-
// Pause Failed is second priority because pause issue might be caused by configuration error.
250+
// Treat the pause failure as the second priority because the issue might be caused by a configuration mistake.
251251
if (pauseFailedException != null) {
252252
if (pauserException == null) {
253253
pauserException = pauseFailedException;
@@ -256,8 +256,8 @@ PauserException buildException(
256256
}
257257
}
258258

259-
// Get target issue is third priority because this issue might be caused by temporary issue, for
260-
// example, network issues.
259+
// Treat the getting target failure as the third priority because this issue might be caused by a temporary glitch, for
260+
// example, network failures.
261261
if (getTargetAfterPauseFailedException != null) {
262262
if (pauserException == null) {
263263
pauserException = getTargetAfterPauseFailedException;
@@ -266,7 +266,7 @@ PauserException buildException(
266266
}
267267
}
268268

269-
// Status check issue is third priority because this issue might be caused by temporary issue,
269+
// Treat the status checking failure as third priority because this issue might be caused by a temporary glitch,
270270
// for example, targetAfterPause is null.
271271
if (statusCheckFailedException != null) {
272272
if (pauserException == null) {
@@ -276,8 +276,8 @@ PauserException buildException(
276276
}
277277
}
278278

279-
// Status unmatched issue is third priority because this issue might be caused by temporary
280-
// issue, for example, pod restarts.
279+
// Treat the status unmatched issue as third priority because this issue might be caused by temporary
280+
// glitch, for example, pod restarts.
281281
if (statusUnmatchedException != null) {
282282
if (pauserException == null) {
283283
pauserException = statusUnmatchedException;

0 commit comments

Comments
 (0)