Add options for ScalarDB test workflows (#154)

Author: yito88

.github/workflows/cluster-test.yml

@@ -35,6 +35,10 @@ on:
           - partition
           - packet
           - clock
+      enable_one_phase_commit:
+        description: 'Enable one phase commit'
+        default: false
+        type: boolean
       enable_group_commit:
         description: 'Enable Group commit'
         default: false
@@ -44,6 +48,7 @@ on:
         type: choice
         default: snapshot
         options:
+          - read-committed
           - snapshot
           - serializable
       consistency_model:
@@ -147,9 +152,14 @@ jobs:
         OPTS+=" --nemesis ${{ github.event.inputs.nemesis }}"
         OPTS+=" --isolation-level ${{ github.event.inputs.isolation_level }}"
         OPTS+=" --consistency-model ${{ github.event.inputs.consistency_model }}"
+
+        if [ "${{ github.event.inputs.enable_one_phase_commit }}" = "true" ]; then
+          OPTS+=" --enable-one-phase-commit"
+        fi
         if [ "${{ github.event.inputs.enable_group_commit }}" = "true" ]; then
           OPTS+=" --enable-group-commit"
         fi
+
         lein with-profile cluster run test \
           --nodes localhost \
           --db cluster \

.github/workflows/daily.yml

@@ -17,45 +17,83 @@ jobs:
           - name: "Transfers_SI"
             workload: "transfer transfer-append"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "snapshot"
             consistency_model: "snapshot-isolation"
+            time_limit: 600
           - name: "Transfers_2PC_SI"
             workload: "transfer-2pc transfer-append-2pc"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "snapshot"
             consistency_model: "snapshot-isolation"
+            time_limit: 600
+          - name: "ReadCommitted"
+            workload: "elle-append elle-write-read"
+            nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
+            enable_group_commit: false
+            isolation_level: "read-committed"
+            consistency_model: "cursor-stability"
+            time_limit: 600
+          - name: "ReadCommitted_2PC"
+            workload: "elle-append-2pc elle-write-read-2pc"
+            nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
+            enable_group_commit: false
+            isolation_level: "read-committed"
+            consistency_model: "cursor-stability"
+            time_limit: 600
           - name: "RCSI"
             workload: "elle-append elle-write-read"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "snapshot"
             consistency_model: "cursor-stability"
+            time_limit: 600
           - name: "RCSI_2PC"
             workload: "elle-append-2pc elle-write-read-2pc"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "snapshot"
             consistency_model: "cursor-stability"
+            time_limit: 600
           - name: "Serializable"
             workload: "elle-append elle-write-read"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "serializable"
             consistency_model: "strict-serializable"
+            time_limit: 600
           - name: "Serializable_2PC"
             workload: "elle-append-2pc elle-write-read-2pc"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: false
             isolation_level: "serializable"
             consistency_model: "strict-serializable"
+            time_limit: 600
+          - name: "OnePhaseCommit"
+            workload: "elle-append elle-write-read"
+            nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: true
+            enable_group_commit: false
+            isolation_level: "snapshot"
+            consistency_model: "cursor-stability"
+            time_limit: 600
           - name: "GroupCommit"
             workload: "elle-append elle-write-read"
             nemesis: "none partition packet clock crash"
+            enable_one_phase_commit: false
             enable_group_commit: true
             isolation_level: "serializable"
             consistency_model: "strict-serializable"
+            time_limit: 600
 
     steps:
     - uses: actions/checkout@v4
@@ -147,11 +185,14 @@ jobs:
         done
         OPTS+=" --isolation-level ${{ matrix.tests.isolation_level }}"
         OPTS+=" --consistency-model ${{ matrix.tests.consistency_model }}"
+        if [ "${{ matrix.tests.enable_one_phase_commit }}" = "true" ]; then
+          OPTS+=" --enable-one-phase-commit"
+        fi
         if [ "${{ matrix.tests.enable_group_commit }}" = "true" ]; then
           OPTS+=" --enable-group-commit"
         fi
         lein with-profile cluster run test \
-          --time-limit 600 \
+          --time-limit ${{ matrix.tests.time_limit }} \
           --nodes localhost \
           --db cluster \
           --concurrency 5 \

scalardb/src/scalardb/db/cluster.clj

@@ -54,7 +54,11 @@
         new-db-props (-> values
                          (get-in path)
                          (str "\nscalar.db.consensus_commit.isolation_level="
-                              (-> test :isolation-level name str/upper-case)))]
+                              (-> test
+                                  :isolation-level
+                                  name
+                                  str/upper-case
+                                  (str/replace #"-" "_"))))]
     (assoc-in values path new-db-props)))
 
 (defn- install!