Apply suggestions

Author: KodaiD

.github/workflows/permission-check.yaml

@@ -115,4 +115,4 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: dynamo_permission_integration_test_reports
-          path: core/build/reports/tests/integrationTestDynamoPermission
+          path: core/build/reports/tests/integrationTestDynamoPermission

core/build.gradle

@@ -140,8 +140,8 @@ dependencies {
     implementation platform("software.amazon.awssdk:bom:${awssdkVersion}")
     implementation 'software.amazon.awssdk:applicationautoscaling'
     implementation 'software.amazon.awssdk:dynamodb'
-    implementation 'software.amazon.awssdk:iam'
-    implementation 'software.amazon.awssdk:iam-policy-builder'
+    testImplementation 'software.amazon.awssdk:iam'
+    testImplementation 'software.amazon.awssdk:iam-policy-builder'
     implementation "org.apache.commons:commons-dbcp2:${commonsDbcp2Version}"
     implementation "com.mysql:mysql-connector-j:${mysqlDriverVersion}"
     implementation "org.postgresql:postgresql:${postgresqlDriverVersion}"

core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoPermissionTestUtils.java

@@ -6,6 +6,7 @@
 import java.util.Properties;
 import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
 import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
+import software.amazon.awssdk.core.exception.SdkException;
 import software.amazon.awssdk.policybuilder.iam.IamEffect;
 import software.amazon.awssdk.policybuilder.iam.IamPolicy;
 import software.amazon.awssdk.policybuilder.iam.IamResource;
@@ -79,18 +80,34 @@ public void grantRequiredPermission(String userName) {
       User user = client.getUser().user();
       Optional<String> attachedPolicyArn = getAttachedPolicyArn(user.userName());
       if (attachedPolicyArn.isPresent()) {
-        deleteStalePolicyVersions(attachedPolicyArn.get());
-        createNewPolicyVersion(attachedPolicyArn.get());
+        String policyArn = attachedPolicyArn.get();
+        try {
+          deleteStalePolicyVersions(policyArn);
+          createNewPolicyVersion(policyArn);
+        } catch (SdkException e) {
+          throw new RuntimeException(
+              String.format(
+                  "Failed to update policy for user: %s, policyArn: %s", userName, policyArn),
+              e);
+        }
       } else {
         String policyArn = createNewPolicy();
-        client.attachUserPolicy(
-            AttachUserPolicyRequest.builder()
-                .userName(user.userName())
-                .policyArn(policyArn)
-                .build());
+        try {
+          client.attachUserPolicy(
+              AttachUserPolicyRequest.builder()
+                  .userName(user.userName())
+                  .policyArn(policyArn)
+                  .build());
+        } catch (SdkException e) {
+          throw new RuntimeException(
+              String.format(
+                  "Failed to attach new policy for user: %s, policyArn: %s", userName, policyArn),
+              e);
+        }
       }
-    } catch (Exception e) {
-      throw new RuntimeException("Failed to grant required permissions", e);
+    } catch (SdkException e) {
+      throw new RuntimeException(
+          String.format("Failed to grant required permissions for user: %s", userName), e);
     }
   }