Fix

Author: KodaiD

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminCaseSensitivityIntegrationTest.java

@@ -83,6 +83,12 @@ private boolean isWideningColumnTypeConversionNotFullySupported() {
     return JdbcTestUtils.isOracle(rdbEngine) || JdbcTestUtils.isSqlite(rdbEngine);
   }
 
+  @Test
+  @Override
+  @DisabledIf("isSqlite")
+  public void
+      dropNamespace_ForNamespaceWithNonScalarDBManagedTables_ShouldThrowIllegalArgumentException() {}
+
   @Test
   @Override
   @DisabledIf("isDb2")

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminIntegrationTest.java

@@ -84,6 +84,12 @@ private boolean isWideningColumnTypeConversionNotFullySupported() {
     return JdbcTestUtils.isOracle(rdbEngine) || JdbcTestUtils.isSqlite(rdbEngine);
   }
 
+  @Test
+  @Override
+  @DisabledIf("isSqlite")
+  public void
+      dropNamespace_ForNamespaceWithNonScalarDBManagedTables_ShouldThrowIllegalArgumentException() {}
+
   @Test
   @Override
   @DisabledIf("isDb2")

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminTestUtils.java

@@ -71,10 +71,13 @@ public void deleteMetadata(String namespace, String table) throws Exception {
             + rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.METADATA_TABLE)
             + " WHERE "
             + rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
-            + " = '"
-            + getFullTableName(namespace, table)
-            + "'";
-    execute(deleteMetadataStatement);
+            + " = ?";
+    try (Connection connection = dataSource.getConnection();
+        PreparedStatement preparedStatement =
+            connection.prepareStatement(deleteMetadataStatement)) {
+      preparedStatement.setString(1, getFullTableName(namespace, table));
+      preparedStatement.executeUpdate();
+    }
   }
 
   private void execute(String sql) throws SQLException {

core/src/integration-test/java/com/scalar/db/storage/multistorage/MultiStorageAdminTestUtils.java

@@ -126,10 +126,13 @@ public void deleteMetadata(String namespace, String table) throws Exception {
             + rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE)
             + " WHERE "
             + rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
-            + " = '"
-            + getFullTableName(namespace, table)
-            + "'";
-    execute(deleteMetadataStatement);
+            + " = ?";
+    try (Connection connection = dataSource.getConnection();
+        PreparedStatement preparedStatement =
+            connection.prepareStatement(deleteMetadataStatement)) {
+      preparedStatement.setString(1, getFullTableName(namespace, table));
+      preparedStatement.executeUpdate();
+    }
   }
 
   @Override

core/src/main/java/com/scalar/db/storage/cosmos/CosmosAdmin.java

@@ -355,6 +355,7 @@ public void dropNamespace(String namespace) throws ExecutionException {
           .deleteItem(new CosmosNamespace(namespace), new CosmosItemRequestOptions());
       deleteMetadataDatabaseIfEmpty();
     } catch (RuntimeException e) {
+      e.printStackTrace();
       throw new ExecutionException(String.format("Deleting the %s database failed", namespace), e);
     }
   }

core/src/main/java/com/scalar/db/storage/jdbc/JdbcAdmin.java

@@ -712,6 +712,9 @@ public Set<String> getNamespaceTableNames(String namespace) throws ExecutionExce
   private Set<String> getNamespaceTableNamesInternal(Connection connection, String namespace)
       throws SQLException {
     String sql = rdbEngine.getTableNamesInNamespaceSql();
+    if (Strings.isNullOrEmpty(sql)) {
+      return Collections.emptySet();
+    }
     Set<String> tableNames = new HashSet<>();
     try (PreparedStatement statement = connection.prepareStatement(sql)) {
       statement.setString(1, namespace);

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineSqlite.java

@@ -370,6 +370,7 @@ public void setConnectionToReadOnly(Connection connection, boolean readOnly) {
 
   @Override
   public String getTableNamesInNamespaceSql() {
-    return "SELECT name FROM sqlite_master WHERE type='table' AND name LIKE ?";
+    // Do nothing. Namespace is just a table prefix in the SQLite implementation.
+    return null;
   }
 }