Skip to content

Commit 4119ccf

Browse files
committed
Fix test
1 parent ff63b5a commit 4119ccf

File tree

4 files changed

+40
-0
lines changed

4 files changed

+40
-0
lines changed

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ObjectStorageMultipleClusteringKeyScanIntegrationTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ protected boolean isParallelDdlSupported() {
2121
return false;
2222
}
2323

24+
@Override
25+
protected Column<?> getColumnWithMinValue(String columnName, DataType dataType) {
26+
if (dataType == DataType.TEXT && ObjectStorageEnv.isS3()) {
27+
// Since S3 and Cloud Storage can't handle "\u0001" character correctly, we use " " as the min
28+
// value
29+
return TextColumn.of(columnName, " ");
30+
}
31+
return super.getColumnWithMinValue(columnName, dataType);
32+
}
33+
2434
@Override
2535
protected Column<?> getColumnWithMaxValue(String columnName, DataType dataType) {
2636
if (dataType == DataType.TEXT

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ObjectStorageMultiplePartitionKeyIntegrationTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ protected boolean isParallelDdlSupported() {
2121
return false;
2222
}
2323

24+
@Override
25+
protected Column<?> getColumnWithMinValue(String columnName, DataType dataType) {
26+
if (dataType == DataType.TEXT && ObjectStorageEnv.isS3()) {
27+
// Since S3 and Cloud Storage can't handle "\u0001" character correctly, we use " " as the min
28+
// value
29+
return TextColumn.of(columnName, " ");
30+
}
31+
return super.getColumnWithMinValue(columnName, dataType);
32+
}
33+
2434
@Override
2535
protected Column<?> getColumnWithMaxValue(String columnName, DataType dataType) {
2636
if (dataType == DataType.TEXT

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ObjectStorageSingleClusteringKeyScanIntegrationTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@ protected Properties getProperties(String testName) {
1616
return ObjectStorageEnv.getProperties(testName);
1717
}
1818

19+
@Override
20+
protected Column<?> getColumnWithMinValue(String columnName, DataType dataType) {
21+
if (dataType == DataType.TEXT && ObjectStorageEnv.isS3()) {
22+
// Since S3 and Cloud Storage can't handle "\u0001" character correctly, we use " " as the min
23+
// value
24+
return TextColumn.of(columnName, " ");
25+
}
26+
return super.getColumnWithMinValue(columnName, dataType);
27+
}
28+
1929
@Override
2030
protected Column<?> getColumnWithMaxValue(String columnName, DataType dataType) {
2131
if (dataType == DataType.TEXT

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ObjectStorageSinglePartitionKeyIntegrationTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@ protected Properties getProperties(String testName) {
1616
return ObjectStorageEnv.getProperties(testName);
1717
}
1818

19+
@Override
20+
protected Column<?> getColumnWithMinValue(String columnName, DataType dataType) {
21+
if (dataType == DataType.TEXT && ObjectStorageEnv.isS3()) {
22+
// Since S3 and Cloud Storage can't handle "\u0001" character correctly, we use " " as the min
23+
// value
24+
return TextColumn.of(columnName, " ");
25+
}
26+
return super.getColumnWithMinValue(columnName, dataType);
27+
}
28+
1929
@Override
2030
protected Column<?> getColumnWithMaxValue(String columnName, DataType dataType) {
2131
if (dataType == DataType.TEXT

0 commit comments

Comments
 (0)