success log argument deprecated and added new cli argument

Author: inv-jishnu

data-loader/cli/src/main/java/com/scalar/db/dataloader/cli/command/dataimport/ImportCommand.java

@@ -286,6 +286,11 @@ private void validateDeprecatedOptions() {
         DEPRECATED_THREADS_OPTION,
         MAX_THREADS_OPTION,
         MAX_THREADS_OPTION_SHORT);
+    validateDeprecatedOptionPair(
+        spec.commandLine(),
+        DEPRECATED_LOG_SUCCESS_RECORDS_OPTION,
+        ENABLE_LOG_SUCCESS_RECORDS_OPTION,
+        ENABLE_LOG_SUCCESS_RECORDS_OPTION_SHORT);
   }
 
   /**
@@ -303,7 +308,7 @@ private ImportOptions createImportOptions(ControlFile controlFile) {
             .controlFile(controlFile)
             .controlFileValidationLevel(controlFileValidation)
             .logRawRecord(logRawRecord)
-            .logSuccessRecords(logSuccessRecords)
+            .logSuccessRecords(enableLogSuccessRecords)
             .ignoreNullValues(ignoreNullValues)
             .namespace(namespace)
             .dataChunkSize(dataChunkSize)

data-loader/cli/src/main/java/com/scalar/db/dataloader/cli/command/dataimport/ImportCommandOptions.java

@@ -13,6 +13,10 @@ public class ImportCommandOptions {
   public static final String MAX_THREADS_OPTION_SHORT = "-mt";
   public static final String DEPRECATED_THREADS_OPTION = "--threads";
 
+  public static final String ENABLE_LOG_SUCCESS_RECORDS_OPTION = "--enable-log-success";
+  public static final String ENABLE_LOG_SUCCESS_RECORDS_OPTION_SHORT = "-ls";
+  public static final String DEPRECATED_LOG_SUCCESS_RECORDS_OPTION = "--log-success";
+
   @CommandLine.Option(
       names = {"--mode", "-m"},
       description = "ScalarDB mode (STORAGE, TRANSACTION) (default: STORAGE)",
@@ -69,11 +73,19 @@ public class ImportCommandOptions {
       description = "Path to the JSON control file for data mapping")
   protected String controlFilePath;
 
+  // Deprecated option - kept for backward compatibility
   @CommandLine.Option(
-      names = {"--log-success", "-ls"},
+      names = {"--log-success"},
+      description = "Deprecated: Use --enable-log-success",
+      hidden = true)
+  @Deprecated
+  protected boolean logSuccessRecordsDeprecated;
+
+  @CommandLine.Option(
+      names = {"--enable-log-success", "-ls"},
       description = "Enable logging of successfully processed records (default: false)",
       defaultValue = "false")
-  protected boolean logSuccessRecords;
+  protected boolean enableLogSuccessRecords;
 
   @CommandLine.Option(
       names = {"--log-dir", "-ld"},
@@ -183,5 +195,8 @@ public void applyDeprecatedOptions() {
     if (threadsDeprecated != null) {
       maxThreads = threadsDeprecated;
     }
+    if (logSuccessRecordsDeprecated) {
+      enableLogSuccessRecords = true;
+    }
   }
 }