Skip to content

Commit 4e647c7

Browse files
committed
Resolve conflicts
1 parent c26d52d commit 4e647c7

File tree

2 files changed

+5
-30
lines changed

2 files changed

+5
-30
lines changed

core/src/main/java/com/scalar/db/storage/objectstorage/ObjectStorageAdmin.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,22 +48,6 @@ public ObjectStorageAdmin(DatabaseConfig databaseConfig) {
4848
metadataNamespace = objectStorageConfig.getMetadataNamespace();
4949
}
5050

51-
@Override
52-
public TableMetadata getImportTableMetadata(
53-
String namespace, String table, Map<String, DataType> overrideColumnsType)
54-
throws ExecutionException {
55-
throw new UnsupportedOperationException(
56-
CoreError.OBJECT_STORAGE_IMPORT_NOT_SUPPORTED.buildMessage());
57-
}
58-
59-
@Override
60-
public void addRawColumnToTable(
61-
String namespace, String table, String columnName, DataType columnType)
62-
throws ExecutionException {
63-
throw new UnsupportedOperationException(
64-
CoreError.OBJECT_STORAGE_IMPORT_NOT_SUPPORTED.buildMessage());
65-
}
66-
6751
@Override
6852
public StorageInfo getStorageInfo(String namespace) throws ExecutionException {
6953
return STORAGE_INFO;

core/src/test/java/com/scalar/db/storage/objectstorage/ObjectStorageAdminTest.java

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,8 @@ public class ObjectStorageAdminTest {
3232

3333
@Mock private ObjectStorageWrapper wrapper;
3434
@Mock private ObjectStorageConfig config;
35-
private ObjectStorageAdmin admin;
36-
37-
@Captor private ArgumentCaptor<String> objectKeyCaptor;
3835
@Captor private ArgumentCaptor<String> payloadCaptor;
36+
private ObjectStorageAdmin admin;
3937

4038
@BeforeEach
4139
public void setUp() throws Exception {
@@ -127,20 +125,15 @@ public void unsupportedOperations_ShouldThrowUnsupportedException() {
127125
catchThrowable(() -> admin.createIndex(namespace, table, column, Collections.emptyMap()));
128126
Throwable thrown2 = catchThrowable(() -> admin.dropIndex(namespace, table, column));
129127
Throwable thrown3 =
130-
catchThrowable(
131-
() -> admin.getImportTableMetadata(namespace, table, Collections.emptyMap()));
132-
Throwable thrown4 =
133-
catchThrowable(() -> admin.addRawColumnToTable(namespace, table, column, DataType.INT));
134-
Throwable thrown5 =
135128
catchThrowable(
136129
() ->
137130
admin.importTable(
138131
namespace, table, Collections.emptyMap(), Collections.emptyMap()));
139-
Throwable thrown6 = catchThrowable(() -> admin.dropColumnFromTable(namespace, table, column));
140-
Throwable thrown7 =
132+
Throwable thrown4 = catchThrowable(() -> admin.dropColumnFromTable(namespace, table, column));
133+
Throwable thrown5 =
141134
catchThrowable(() -> admin.renameColumn(namespace, table, column, "newCol"));
142-
Throwable thrown8 = catchThrowable(() -> admin.renameTable(namespace, table, "newTable"));
143-
Throwable thrown9 =
135+
Throwable thrown6 = catchThrowable(() -> admin.renameTable(namespace, table, "newTable"));
136+
Throwable thrown7 =
144137
catchThrowable(() -> admin.alterColumnType(namespace, table, column, DataType.INT));
145138

146139
// Assert
@@ -151,8 +144,6 @@ public void unsupportedOperations_ShouldThrowUnsupportedException() {
151144
assertThat(thrown5).isInstanceOf(UnsupportedOperationException.class);
152145
assertThat(thrown6).isInstanceOf(UnsupportedOperationException.class);
153146
assertThat(thrown7).isInstanceOf(UnsupportedOperationException.class);
154-
assertThat(thrown8).isInstanceOf(UnsupportedOperationException.class);
155-
assertThat(thrown9).isInstanceOf(UnsupportedOperationException.class);
156147
}
157148

158149
@Test

0 commit comments

Comments
 (0)