Skip to content

Commit 4e9a18e

Browse files
committed
Fix based on feedback
1 parent 5a18d4e commit 4e9a18e

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import java.util.Map;
55
import java.util.Properties;
66

7-
public class ObjectStorageMutationAtomicityUnitIntegrationTest
7+
public class ObjectStorageAtomicityUnitIntegrationTest
88
extends DistributedStorageAtomicityUnitIntegrationTestBase {
99

1010
@Override

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineDb2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ public String getTableNamesInNamespaceSql() {
592592

593593
@Override
594594
public int getMinimumIsolationLevelForConsistencyRead() {
595-
// In Db2, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistency reads
595+
// In Db2, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistent reads
596596
return Connection.TRANSACTION_REPEATABLE_READ;
597597
}
598598
}

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineMysql.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ public String getTableNamesInNamespaceSql() {
512512

513513
@Override
514514
public int getMinimumIsolationLevelForConsistencyRead() {
515-
// In MySQL, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistency reads.
515+
// In MySQL, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistent reads.
516516
return Connection.TRANSACTION_REPEATABLE_READ;
517517
}
518518
}

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ public String getTableNamesInNamespaceSql() {
544544

545545
@Override
546546
public int getMinimumIsolationLevelForConsistencyRead() {
547-
// In Oracle, only the SERIALIZABLE isolation level guarantees the consistency read
547+
// In Oracle, only the SERIALIZABLE isolation level guarantees consistent reads
548548
return Connection.TRANSACTION_SERIALIZABLE;
549549
}
550550
}

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineSqlServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ public String getTableNamesInNamespaceSql() {
440440

441441
@Override
442442
public int getMinimumIsolationLevelForConsistencyRead() {
443-
// In SQL Server, REPEATABLE READ or higher isolation level guarantees the consistency read
443+
// In SQL Server, REPEATABLE READ or higher isolation level guarantees consistent reads
444444
return Connection.TRANSACTION_REPEATABLE_READ;
445445
}
446446
}

core/src/main/java/com/scalar/db/storage/objectstorage/ObjectStorageWrapper.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,10 @@ public interface ObjectStorageWrapper {
7676
*/
7777
void deleteByPrefix(String prefix) throws ObjectStorageWrapperException;
7878

79-
/** Close the storage wrapper. */
79+
/**
80+
* Close the storage wrapper.
81+
*
82+
* @throws ObjectStorageWrapperException if an error occurs
83+
*/
8084
void close() throws ObjectStorageWrapperException;
8185
}

0 commit comments

Comments
 (0)