Skip to content

Commit 517675a

Browse files
committed
Add waits
1 parent 94af094 commit 517675a

File tree

3 files changed

+50
-4
lines changed

3 files changed

+50
-4
lines changed

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ConsensusCommitIntegrationTestWithObjectStorage.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,35 @@
11
package com.scalar.db.storage.objectstorage;
22

3+
import com.google.common.util.concurrent.Uninterruptibles;
34
import com.scalar.db.api.TableMetadata;
45
import com.scalar.db.io.DataType;
56
import com.scalar.db.transaction.consensuscommit.ConsensusCommitIntegrationTestBase;
67
import java.util.Properties;
8+
import java.util.concurrent.TimeUnit;
9+
import org.junit.jupiter.api.AfterEach;
10+
import org.junit.jupiter.api.BeforeEach;
711
import org.junit.jupiter.api.Disabled;
812

913
public class ConsensusCommitIntegrationTestWithObjectStorage
1014
extends ConsensusCommitIntegrationTestBase {
1115

16+
@Override
17+
@BeforeEach
18+
public void setUp() throws Exception {
19+
admin.truncateTable(namespace, TABLE);
20+
admin.truncateCoordinatorTables();
21+
if (ObjectStorageEnv.isCloudStorage()) {
22+
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
23+
}
24+
}
25+
26+
@AfterEach
27+
void tearDown() {
28+
if (ObjectStorageEnv.isCloudStorage()) {
29+
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
30+
}
31+
}
32+
1233
@Override
1334
protected TableMetadata getTableMetadata() {
1435
return TableMetadata.newBuilder()

core/src/integration-test/java/com/scalar/db/storage/objectstorage/ConsensusCommitSpecificIntegrationTestWithObjectStorage.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,40 @@
11
package com.scalar.db.storage.objectstorage;
22

3+
import com.google.common.util.concurrent.Uninterruptibles;
34
import com.scalar.db.api.TableMetadata;
45
import com.scalar.db.io.DataType;
56
import com.scalar.db.transaction.consensuscommit.ConsensusCommitSpecificIntegrationTestBase;
67
import com.scalar.db.transaction.consensuscommit.Isolation;
78
import java.util.Properties;
9+
import java.util.concurrent.TimeUnit;
10+
import org.junit.jupiter.api.AfterEach;
11+
import org.junit.jupiter.api.BeforeEach;
812
import org.junit.jupiter.api.Disabled;
913

1014
public class ConsensusCommitSpecificIntegrationTestWithObjectStorage
1115
extends ConsensusCommitSpecificIntegrationTestBase {
1216

17+
@Override
18+
@BeforeEach
19+
protected void setUp() throws Exception {
20+
truncateTables();
21+
if (ObjectStorageEnv.isCloudStorage()) {
22+
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
23+
}
24+
}
25+
26+
@Override
27+
@AfterEach
28+
public void tearDown() {
29+
recoveryExecutor.close();
30+
if (groupCommitter != null) {
31+
groupCommitter.close();
32+
}
33+
if (ObjectStorageEnv.isCloudStorage()) {
34+
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
35+
}
36+
}
37+
1338
@Override
1439
protected TableMetadata getTableMetadata() {
1540
return TableMetadata.newBuilder()

integration-test/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitSpecificIntegrationTestBase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ public abstract class ConsensusCommitSpecificIntegrationTestBase {
112112
private DistributedStorage storage;
113113
private Coordinator coordinator;
114114
private RecoveryHandler recovery;
115-
private RecoveryExecutor recoveryExecutor;
115+
protected RecoveryExecutor recoveryExecutor;
116116
private CommitHandler commit;
117-
@Nullable private CoordinatorGroupCommitter groupCommitter;
117+
@Nullable protected CoordinatorGroupCommitter groupCommitter;
118118

119119
@BeforeAll
120120
void beforeAll() throws Exception {
@@ -174,7 +174,7 @@ protected Map<String, String> getCreationOptions() {
174174
}
175175

176176
@BeforeEach
177-
void setUp() throws Exception {
177+
protected void setUp() throws Exception {
178178
truncateTables();
179179
}
180180

@@ -186,7 +186,7 @@ public void tearDown() {
186186
}
187187
}
188188

189-
private void truncateTables() throws ExecutionException {
189+
protected void truncateTables() throws ExecutionException {
190190
consensusCommitAdmin.truncateTable(namespace1, TABLE_1);
191191
consensusCommitAdmin.truncateTable(namespace2, TABLE_2);
192192
consensusCommitAdmin.truncateCoordinatorTables();

0 commit comments

Comments
 (0)