Skip to content

Commit 53383a9

Browse files
authored
Add alter column type (#3028)
1 parent cc604d2 commit 53383a9

File tree

54 files changed

+3179
-119
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+3179
-119
lines changed

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7777
}
7878
}
7979

80+
@Override
81+
@Disabled("Cassandra does not support altering column types")
82+
public void
83+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
84+
85+
@Override
86+
@Disabled("Cassandra does not support altering column types")
87+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
88+
89+
@Override
90+
@Disabled("Cassandra does not support altering column types")
91+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
92+
8093
@Override
8194
@Disabled("Cassandra does not support renaming tables")
8295
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminIntegrationTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7676
}
7777
}
7878

79+
@Override
80+
@Disabled("Cassandra does not support altering column types")
81+
public void
82+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
83+
84+
@Override
85+
@Disabled("Cassandra does not support altering column types")
86+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
87+
88+
@Override
89+
@Disabled("Cassandra does not support altering column types")
90+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
91+
7992
@Override
8093
@Disabled("Cassandra does not support renaming tables")
8194
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminPermissionIntegrationTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@ public void renameColumn_WithSufficientPermission_ShouldSucceed() throws Executi
154154
.doesNotThrowAnyException();
155155
}
156156

157+
@Test
158+
@Override
159+
@Disabled("Cassandra does not support altering column types")
160+
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}
161+
157162
@Test
158163
@Override
159164
@Disabled("Cassandra does not support renaming tables")

core/src/integration-test/java/com/scalar/db/storage/cassandra/ConsensusCommitAdminIntegrationTestWithCassandra.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7676
}
7777
}
7878

79+
@Override
80+
@Disabled("Cassandra does not support altering column types")
81+
public void
82+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
83+
84+
@Override
85+
@Disabled("Cassandra does not support altering column types")
86+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
87+
88+
@Override
89+
@Disabled("Cassandra does not support altering column types")
90+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
91+
7992
@Override
8093
@Disabled("Cassandra does not support renaming tables")
8194
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cassandra/SingleCrudOperationTransactionAdminIntegrationTestWithCassandra.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7171
}
7272
}
7373

74+
@Override
75+
@Disabled("Cassandra does not support altering column types")
76+
public void
77+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
78+
79+
@Override
80+
@Disabled("Cassandra does not support altering column types")
81+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
82+
83+
@Override
84+
@Disabled("Cassandra does not support altering column types")
85+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
86+
7487
@Override
7588
@Disabled("Cassandra does not support renaming tables")
7689
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cosmos/ConsensusCommitAdminIntegrationTestWithCosmos.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6868
@Disabled("Cosmos DB does not support renaming columns")
6969
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7070

71+
@Override
72+
@Disabled("Cosmos DB does not support altering column types")
73+
public void
74+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
75+
76+
@Override
77+
@Disabled("Cosmos DB does not support altering column types")
78+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
79+
80+
@Override
81+
@Disabled("Cosmos DB does not support altering column types")
82+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
83+
7184
@Override
7285
@Disabled("Cosmos DB does not support renaming tables")
7386
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6868
@Disabled("Cosmos DB does not support renaming columns")
6969
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7070

71+
@Override
72+
@Disabled("Cosmos DB does not support altering column types")
73+
public void
74+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
75+
76+
@Override
77+
@Disabled("Cosmos DB does not support altering column types")
78+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
79+
80+
@Override
81+
@Disabled("Cosmos DB does not support altering column types")
82+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
83+
7184
@Override
7285
@Disabled("Cosmos DB does not support renaming tables")
7386
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6767
@Disabled("Cosmos DB does not support renaming columns")
6868
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
6969

70+
@Override
71+
@Disabled("Cosmos DB does not support altering column types")
72+
public void
73+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
74+
75+
@Override
76+
@Disabled("Cosmos DB does not support altering column types")
77+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
78+
79+
@Override
80+
@Disabled("Cosmos DB does not support altering column types")
81+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
82+
7083
@Override
7184
@Disabled("Cosmos DB does not support renaming tables")
7285
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/cosmos/SingleCrudOperationTransactionAdminIntegrationTestWithCosmos.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6262
@Disabled("Cosmos DB does not support renaming columns")
6363
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
6464

65+
@Override
66+
@Disabled("Cosmos DB does not support altering column types")
67+
public void
68+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
69+
70+
@Override
71+
@Disabled("Cosmos DB does not support altering column types")
72+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
73+
74+
@Override
75+
@Disabled("Cosmos DB does not support altering column types")
76+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
77+
6578
@Override
6679
@Disabled("Cosmos DB does not support renaming tables")
6780
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

core/src/integration-test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
7373
@Disabled("DynamoDB does not support renaming columns")
7474
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7575

76+
@Override
77+
@Disabled("DynamoDB does not support altering column types")
78+
public void
79+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
80+
81+
@Override
82+
@Disabled("DynamoDB does not support altering column types")
83+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
84+
85+
@Override
86+
@Disabled("DynamoDB does not support altering column types")
87+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
88+
7689
@Override
7790
@Disabled("DynamoDB does not support renaming tables")
7891
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

0 commit comments

Comments
 (0)