Skip to content

Commit 539bfa8

Browse files
committed
Apply suggestions
1 parent 6626c93 commit 539bfa8

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

core/src/main/java/com/scalar/db/storage/cosmos/CosmosAdmin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ public class CosmosAdmin implements DistributedStorageAdmin {
5757

5858
public static final String TABLE_METADATA_CONTAINER = "metadata";
5959
public static final String NAMESPACES_CONTAINER = "namespaces";
60-
@VisibleForTesting public static final String STORED_PROCEDURE_FILE_NAME = "mutate.js";
6160
private static final String ID = "id";
6261
private static final String CONCATENATED_PARTITION_KEY = "concatenatedPartitionKey";
6362
private static final String PARTITION_KEY_PATH = "/" + CONCATENATED_PARTITION_KEY;
6463
private static final String CLUSTERING_KEY_PATH_PREFIX = "/clusteringKey/";
6564
private static final String SECONDARY_INDEX_KEY_PATH_PREFIX = "/values/";
6665
private static final String EXCLUDED_PATH = "/*";
66+
@VisibleForTesting public static final String STORED_PROCEDURE_FILE_NAME = "mutate.js";
6767
private static final String STORED_PROCEDURE_PATH =
6868
"cosmosdb_stored_procedure/" + STORED_PROCEDURE_FILE_NAME;
6969
private static final StorageInfo STORAGE_INFO =

core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTest.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2187,6 +2187,12 @@ public void dropNamespace_WithNonScalarDBTableLeftForOracle_ShouldThrowIllegalAr
21872187
RdbEngine.ORACLE);
21882188
}
21892189

2190+
@Test
2191+
public void dropNamespace_WithNonScalarDBTableLeftForSqlite_ShouldThrowIllegalArgumentException()
2192+
throws Exception {
2193+
// Do nothing. SQLite does not have a concept of namespaces.
2194+
}
2195+
21902196
@Test
21912197
public void dropNamespace_WithNonScalarDBTableLeftForDb2_ShouldThrowIllegalArgumentException()
21922198
throws Exception {
@@ -2203,19 +2209,14 @@ private void dropNamespace_WithNonScalarDBTableLeftForX_ShouldThrowIllegalArgume
22032209
Statement dropNamespaceStatementMock = mock(Statement.class);
22042210
PreparedStatement deleteFromNamespaceTableMock = mock(PreparedStatement.class);
22052211
Statement selectNamespaceStatementMock = mock(Statement.class);
2206-
if (rdbEngine != RdbEngine.SQLITE) {
2207-
PreparedStatement getTableNamesPrepStmt = mock(PreparedStatement.class);
2208-
when(connection.createStatement())
2209-
.thenReturn(dropNamespaceStatementMock, selectNamespaceStatementMock);
2210-
ResultSet emptyResultSet = mock(ResultSet.class);
2211-
when(emptyResultSet.next()).thenReturn(true).thenReturn(false);
2212-
when(getTableNamesPrepStmt.executeQuery()).thenReturn(emptyResultSet);
2213-
when(connection.prepareStatement(anyString()))
2214-
.thenReturn(getTableNamesPrepStmt, deleteFromNamespaceTableMock);
2215-
} else {
2216-
when(connection.createStatement()).thenReturn(selectNamespaceStatementMock);
2217-
when(connection.prepareStatement(anyString())).thenReturn(deleteFromNamespaceTableMock);
2218-
}
2212+
PreparedStatement getTableNamesPrepStmt = mock(PreparedStatement.class);
2213+
when(connection.createStatement())
2214+
.thenReturn(dropNamespaceStatementMock, selectNamespaceStatementMock);
2215+
ResultSet emptyResultSet = mock(ResultSet.class);
2216+
when(emptyResultSet.next()).thenReturn(true).thenReturn(false);
2217+
when(getTableNamesPrepStmt.executeQuery()).thenReturn(emptyResultSet);
2218+
when(connection.prepareStatement(anyString()))
2219+
.thenReturn(getTableNamesPrepStmt, deleteFromNamespaceTableMock);
22192220
when(dataSource.getConnection()).thenReturn(connection);
22202221
// Namespaces table does not contain other namespaces
22212222
ResultSet resultSet = mock(ResultSet.class);

0 commit comments

Comments
 (0)