Skip to content

Commit 5679f61

Browse files
brfrn169josh-wong
andauthored
[skip ci] Apply suggestions from code review
Co-authored-by: Josh Wong <[email protected]>
1 parent 9902070 commit 5679f61

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

data-loader/core/src/main/java/com/scalar/db/dataloader/core/DataLoaderError.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public enum DataLoaderError implements ScalarDbError {
2727
MISSING_FILE_EXTENSION(
2828
Category.USER_ERROR,
2929
"0004",
30-
"No file extension was found on the provided file name %s",
30+
"No file extension was found in the provided file name %s",
3131
"",
3232
""),
3333
INVALID_FILE_EXTENSION(
@@ -68,13 +68,13 @@ public enum DataLoaderError implements ScalarDbError {
6868
CLUSTERING_KEY_ORDER_MISMATCH(
6969
Category.USER_ERROR,
7070
"0013",
71-
"The provided clustering key order does not match the table schema. Required order: %s",
71+
"The provided clustering-key order does not match the table schema. Required order: %s",
7272
"",
7373
""),
7474
PARTITION_KEY_ORDER_MISMATCH(
7575
Category.USER_ERROR,
7676
"0014",
77-
"The provided partition key order does not match the table schema. Required order: %s",
77+
"The provided partition-key order does not match the table schema. Required order: %s",
7878
"",
7979
""),
8080
MISSING_NAMESPACE_OR_TABLE(
@@ -156,7 +156,7 @@ public enum DataLoaderError implements ScalarDbError {
156156
MISSING_SOURCE_FIELD(
157157
Category.USER_ERROR,
158158
"0035",
159-
"The data mapping source field '%s' for table '%s' is missing in the json data record",
159+
"The data mapping source field '%s' for table '%s' is missing in the JSON data record",
160160
"",
161161
""),
162162
CSV_DATA_MISMATCH(
@@ -166,7 +166,7 @@ public enum DataLoaderError implements ScalarDbError {
166166
IMPORT_TARGET_MISSING(
167167
Category.USER_ERROR,
168168
"0038",
169-
"Missing option: either '--namespace' and'--table' or '--control-file' options must be specified",
169+
"Missing option: either the '--namespace' and '--table' options or the '--control-file' option must be specified",
170170
"",
171171
""),
172172
MISSING_IMPORT_FILE(
@@ -199,7 +199,7 @@ public enum DataLoaderError implements ScalarDbError {
199199
"",
200200
""),
201201
NULL_OR_EMPTY_KEY_VALUE_INPUT(
202-
Category.USER_ERROR, "0049", "Key-value cannot be null or empty", "", ""),
202+
Category.USER_ERROR, "0049", "Key value cannot be null or empty", "", ""),
203203
INVALID_KEY_VALUE_INPUT(Category.USER_ERROR, "0050", "Invalid key-value format: %s", "", ""),
204204
SPLIT_INPUT_VALUE_NULL(Category.USER_ERROR, "0051", "Value must not be null", "", ""),
205205
SPLIT_INPUT_DELIMITER_NULL(Category.USER_ERROR, "0052", "Delimiter must not be null", "", ""),
@@ -217,13 +217,13 @@ public enum DataLoaderError implements ScalarDbError {
217217
ERROR_CRUD_EXCEPTION(
218218
Category.INTERNAL_ERROR,
219219
"0000",
220-
"Something went wrong while trying to save the data. Details: %s",
220+
"A problem occurred while trying to save the data. Details: %s",
221221
"",
222222
""),
223223
ERROR_SCAN(
224224
Category.INTERNAL_ERROR,
225225
"0001",
226-
"Something went wrong while scanning. Are you sure you are running in the correct transaction mode? Details: %s",
226+
"A problem occurred while scanning. Are you sure you are running in the correct transaction mode? Details: %s",
227227
"",
228228
""),
229229
CSV_FILE_READ_FAILED(

0 commit comments

Comments
 (0)