Apply suggestions

KodaiD · KodaiD · commit 62fb53a8e9ca · 2025-07-30T11:44:25.000+09:00
diff --git a/core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java
@@ -1,13 +1,13 @@
 package com.scalar.db.storage.cassandra;
 
-import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
 import com.scalar.db.util.AdminTestUtils;
 import java.util.Collections;
 import java.util.Map;
 import java.util.Properties;
 
 public class CassandraAdminCaseSensitivityIntegrationTest
-    extends DistributedStorageAdminCaseSensitivityIntegrationTest {
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
   @Override
   protected Properties getProperties(String testName) {
     return CassandraEnv.getProperties(testName);
diff --git a/core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraCaseSensitivityIntegrationTest.java
@@ -1,14 +1,14 @@
 package com.scalar.db.storage.cassandra;
 
-import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
 import java.util.Collections;
 import java.util.Map;
 import java.util.Properties;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 public class CassandraCaseSensitivityIntegrationTest
-    extends DistributedStorageCaseSensitivityIntegrationTest {
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
   @Override
   protected Properties getProperties(String testName) {
     return CassandraEnv.getProperties(testName);
diff --git a/core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java
@@ -1,12 +1,12 @@
 package com.scalar.db.storage.cosmos;
 
-import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
 import com.scalar.db.util.AdminTestUtils;
 import java.util.Map;
 import java.util.Properties;
 
 public class CosmosAdminCaseSensitivityIntegrationTest
-    extends DistributedStorageAdminCaseSensitivityIntegrationTest {
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
 
   @Override
   protected Properties getProperties(String testName) {
diff --git a/core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosCaseSensitivityIntegrationTest.java
@@ -1,11 +1,11 @@
 package com.scalar.db.storage.cosmos;
 
-import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
 import java.util.Map;
 import java.util.Properties;
 
 public class CosmosCaseSensitivityIntegrationTest
-    extends DistributedStorageCaseSensitivityIntegrationTest {
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
 
   @Override
   protected Properties getProperties(String testName) {
diff --git a/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminCaseSensitivityIntegrationTest.java
@@ -1,12 +1,12 @@
 package com.scalar.db.storage.dynamo;
 
-import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
 import com.scalar.db.util.AdminTestUtils;
 import java.util.Map;
 import java.util.Properties;
 
 public class DynamoAdminCaseSensitivityIntegrationTest
-    extends DistributedStorageAdminCaseSensitivityIntegrationTest {
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
 
   @Override
   protected Properties getProperties(String testName) {
diff --git a/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoCaseSensitivityIntegrationTest.java
@@ -1,12 +1,12 @@
 package com.scalar.db.storage.dynamo;
 
-import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
 import java.util.Map;
 import java.util.Properties;
 import org.junit.jupiter.api.Disabled;
 
 public class DynamoCaseSensitivityIntegrationTest
-    extends DistributedStorageCaseSensitivityIntegrationTest {
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
 
   @Override
   protected Properties getProperties(String testName) {
@@ -18,8 +18,7 @@ protected Map<String, String> getCreationOptions() {
     return DynamoEnv.getCreationOptions();
   }
 
-  // DynamoDB doesn't support putting a null value for a secondary index column
-  @Disabled
+  @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")
   @Override
   public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}
 }
diff --git a/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoIntegrationTest.java
@@ -17,8 +17,7 @@ protected Map<String, String> getCreationOptions() {
     return DynamoEnv.getCreationOptions();
   }
 
-  // DynamoDB doesn't support putting a null value for a secondary index column
-  @Disabled
+  @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")
   @Override
   public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}
 }
diff --git a/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoWithReservedKeywordIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoWithReservedKeywordIntegrationTest.java
@@ -60,8 +60,7 @@ protected Map<String, String> getCreationOptions() {
     return DynamoEnv.getCreationOptions();
   }
 
-  // DynamoDB doesn't support putting a null value for a secondary index column
-  @Disabled
+  @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")
   @Override
   public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}
 }
diff --git a/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminCaseSensitivityIntegrationTest.java
@@ -1,12 +1,12 @@
 package com.scalar.db.storage.jdbc;
 
-import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
 import com.scalar.db.config.DatabaseConfig;
 import com.scalar.db.util.AdminTestUtils;
 import java.util.Properties;
 
 public class JdbcAdminCaseSensitivityIntegrationTest
-    extends DistributedStorageAdminCaseSensitivityIntegrationTest {
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
   private RdbEngineStrategy rdbEngine;
 
   @Override
diff --git a/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcDatabaseCaseSensitivityIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcDatabaseCaseSensitivityIntegrationTest.java
@@ -3,7 +3,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import com.scalar.db.api.DistributedStorage;
-import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTest;
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
 import com.scalar.db.api.Get;
 import com.scalar.db.api.Put;
 import com.scalar.db.api.Result;
@@ -20,7 +20,7 @@
 import org.junit.jupiter.api.Test;
 
 public class JdbcDatabaseCaseSensitivityIntegrationTest
-    extends DistributedStorageCaseSensitivityIntegrationTest {
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
 
   private RdbEngineStrategy rdbEngine;
 
diff --git a/integration-test/src/main/java/com/scalar/db/api/DistributedStorageAdminCaseSensitivityIntegrationTestBase.java b/integration-test/src/main/java/com/scalar/db/api/DistributedStorageAdminCaseSensitivityIntegrationTestBase.java
@@ -1,6 +1,6 @@
 package com.scalar.db.api;
 
-public abstract class DistributedStorageAdminCaseSensitivityIntegrationTest
+public abstract class DistributedStorageAdminCaseSensitivityIntegrationTestBase
     extends DistributedStorageAdminIntegrationTestBase {
 
   private static final String TEST_NAME = "storage_admin_case";
diff --git a/integration-test/src/main/java/com/scalar/db/api/DistributedStorageCaseSensitivityIntegrationTestBase.java b/integration-test/src/main/java/com/scalar/db/api/DistributedStorageCaseSensitivityIntegrationTestBase.java
@@ -3,7 +3,7 @@
 import org.junit.jupiter.api.TestInstance;
 
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
-public abstract class DistributedStorageCaseSensitivityIntegrationTest
+public abstract class DistributedStorageCaseSensitivityIntegrationTestBase
     extends DistributedStorageIntegrationTestBase {
 
   private static final String TEST_NAME = "storage_case";

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,7 @@ protected Map<String, String> getCreationOptions() {`
`17`	`17`	`return DynamoEnv.getCreationOptions();`
`18`	`18`	`}`
`19`	`19`
`20`		`- // DynamoDB doesn't support putting a null value for a secondary index column`
`21`		`- @Disabled`
	`20`	`+ @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")`
`22`	`21`	`@Override`
`23`	`22`	`public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}`
`24`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,7 @@ protected Map<String, String> getCreationOptions() {`
`60`	`60`	`return DynamoEnv.getCreationOptions();`
`61`	`61`	`}`
`62`	`62`
`63`		`- // DynamoDB doesn't support putting a null value for a secondary index column`
`64`		`- @Disabled`
	`63`	`+ @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")`
`65`	`64`	`@Override`
`66`	`65`	`public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}`
`67`	`66`	`}`