Fix to handle an issue where MySQL 5.7 does not support RENAME COLUMN statement

Author: KodaiD

core/src/main/java/com/scalar/db/storage/jdbc/JdbcAdmin.java

@@ -908,7 +908,12 @@ public void renameColumn(
       }
       TableMetadata updatedTableMetadata = tableMetadataBuilder.build();
       String renameColumnStatement =
-          rdbEngine.renameColumnSql(namespace, table, oldColumnName, newColumnName);
+          rdbEngine.renameColumnSql(
+              namespace,
+              table,
+              oldColumnName,
+              newColumnName,
+              getVendorDbColumnType(updatedTableMetadata, newColumnName));
       try (Connection connection = dataSource.getConnection()) {
         execute(connection, renameColumnStatement);
         if (currentTableMetadata.getSecondaryIndexNames().contains(oldColumnName)) {

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineMysql.java

@@ -114,6 +114,23 @@ public void dropNamespaceTranslateSQLException(SQLException e, String namespace)
     throw new ExecutionException("Dropping the schema failed: " + namespace, e);
   }
 
+  @Override
+  public String renameColumnSql(
+      String namespace,
+      String table,
+      String oldColumnName,
+      String newColumnName,
+      String columnType) {
+    return "ALTER TABLE "
+        + encloseFullTableName(namespace, table)
+        + " CHANGE COLUMN "
+        + enclose(oldColumnName)
+        + " "
+        + enclose(newColumnName)
+        + " "
+        + columnType;
+  }
+
   @Override
   public String alterColumnTypeSql(
       String namespace, String table, String columnName, String columnType) {

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineSqlServer.java

@@ -103,7 +103,11 @@ public void dropNamespaceTranslateSQLException(SQLException e, String namespace)
 
   @Override
   public String renameColumnSql(
-      String namespace, String table, String oldColumnName, String newColumnName) {
+      String namespace,
+      String table,
+      String oldColumnName,
+      String newColumnName,
+      String columnType) {
     return "EXEC sp_rename '"
         + encloseFullTableName(namespace, table)
         + "."

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineStrategy.java

@@ -108,7 +108,11 @@ default String[] dropColumnSql(String namespace, String table, String columnName
   }
 
   default String renameColumnSql(
-      String namespace, String table, String oldColumnName, String newColumnName) {
+      String namespace,
+      String table,
+      String oldColumnName,
+      String newColumnName,
+      String columnType) {
     return "ALTER TABLE "
         + encloseFullTableName(namespace, table)
         + " RENAME COLUMN "

core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTest.java

@@ -3086,7 +3086,7 @@ public void renameColumn_ForMysql_ShouldWorkProperly() throws SQLException, Exec
         "SELECT `column_name`,`data_type`,`key_type`,`clustering_order`,`indexed` FROM `"
             + METADATA_SCHEMA
             + "`.`metadata` WHERE `full_table_name`=? ORDER BY `ordinal_position` ASC",
-        "ALTER TABLE `ns`.`table` RENAME COLUMN `c2` TO `c3`",
+        "ALTER TABLE `ns`.`table` CHANGE COLUMN `c2` `c3` INT",
         "DELETE FROM `" + METADATA_SCHEMA + "`.`metadata` WHERE `full_table_name` = 'ns.table'",
         "INSERT INTO `"
             + METADATA_SCHEMA