Add integration tests for ConsensusCommitAdmin

Author: KodaiD

core/src/integration-test/java/com/scalar/db/storage/jdbc/ConsensusCommitAdminImportTableIntegrationTestWithJdbcDatabase.java

@@ -3,6 +3,7 @@
 import com.scalar.db.api.DistributedStorageAdminImportTableIntegrationTestBase.TestData;
 import com.scalar.db.exception.storage.ExecutionException;
 import com.scalar.db.transaction.consensuscommit.ConsensusCommitAdminImportTableIntegrationTestBase;
+import com.scalar.db.util.AdminTestUtils;
 import java.sql.SQLException;
 import java.util.List;
 import java.util.Properties;
@@ -53,6 +54,11 @@ protected void dropNonImportableTable(String table) throws SQLException {
     testUtils.dropTable(getNamespace(), table);
   }
 
+  @Override
+  protected AdminTestUtils getAdminTestUtils(String testName) {
+    return new JdbcAdminTestUtils(getProperties(testName));
+  }
+
   @SuppressWarnings("unused")
   private boolean isSqlite() {
     return JdbcEnv.isSqlite();
@@ -72,4 +78,9 @@ public void importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationEx
       throws ExecutionException {
     super.importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationException();
   }
+
+  @Test
+  @Override
+  @DisabledIf("isSqlite")
+  public void dropNamespace_ShouldNotDropNonScalarDBTables() {}
 }

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTableIntegrationTest.java

@@ -271,6 +271,7 @@ public void alterColumnType_Oracle_WideningConversion_ForImportedTable_ShouldAlt
   }
 
   @Test
+  @Override
   @DisabledIf("isSqlite")
   public void dropNamespace_ShouldNotDropNonScalarDBTables() {}
 }

integration-test/src/main/java/com/scalar/db/api/DistributedTransactionAdminImportTableIntegrationTestBase.java

@@ -1,6 +1,7 @@
 package com.scalar.db.api;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import com.scalar.db.api.DistributedStorageAdminImportTableIntegrationTestBase.TestData;
@@ -9,6 +10,7 @@
 import com.scalar.db.io.Column;
 import com.scalar.db.io.DataType;
 import com.scalar.db.service.TransactionFactory;
+import com.scalar.db.util.AdminTestUtils;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashSet;
@@ -104,6 +106,8 @@ protected void afterAll() throws Exception {}
 
   protected abstract void dropNonImportableTable(String table) throws Exception;
 
+  protected abstract AdminTestUtils getAdminTestUtils(String testName);
+
   @Test
   public void importTable_ShouldWorkProperly() throws Exception {
     // Arrange
@@ -134,6 +138,43 @@ public void importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationEx
         .isInstanceOf(UnsupportedOperationException.class);
   }
 
+  @Test
+  public void dropNamespace_ShouldNotDropNonScalarDBTables() throws Exception {
+    AdminTestUtils adminTestUtils = getAdminTestUtils(TEST_NAME);
+    try {
+      // Arrange
+      testDataList.addAll(createExistingDatabaseWithAllDataTypes());
+      for (TestData testData : testDataList) {
+        if (testData.isImportableTable()) {
+          admin.importTable(
+              getNamespace(),
+              testData.getTableName(),
+              Collections.emptyMap(),
+              testData.getOverrideColumnsType());
+        }
+      }
+      for (TestData testData : testDataList) {
+        if (testData.isImportableTable()) {
+          admin.dropTable(getNamespace(), testData.getTableName());
+        }
+      }
+
+      // Act
+      assertThatCode(() -> admin.dropNamespace(getNamespace()))
+          .isInstanceOf(IllegalStateException.class);
+
+      // Assert
+      assertThat(admin.namespaceExists(getNamespace())).isTrue();
+      for (TestData testData : testDataList) {
+        if (!testData.isImportableTable()) {
+          adminTestUtils.tableExists(getNamespace(), testData.getTableName());
+        }
+      }
+    } finally {
+      adminTestUtils.close();
+    }
+  }
+
   private void importTable_ForImportableTable_ShouldImportProperly(
       String table, Map<String, DataType> overrideColumnsType, TableMetadata metadata)
       throws ExecutionException {