Fix

Author: KodaiD

core/src/integration-test/java/com/scalar/db/storage/jdbc/ConsensusCommitAdminImportTableIntegrationTestWithJdbcDatabase.java

@@ -143,7 +143,7 @@ public void importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationEx
           if (!metadata.getPartitionKeyNames().contains(column)
               && !metadata.getClusteringKeyNames().contains(column)) {
             if (metadata.getColumnDataType(column).equals(DataType.BLOB)) {
-              // Conversion from BLOB TO TEXT is not supported in Oracle engine
+              // Conversion from BLOB TO TEXT is not supported in Db2 engine
               continue;
             }
             admin.alterColumnType(getNamespace(), testData.getTableName(), column, DataType.TEXT);

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTableIntegrationTest.java

@@ -9,6 +9,7 @@
 import java.sql.SQLException;
 import java.util.Collections;
 import java.util.List;
+import java.util.Objects;
 import java.util.Properties;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledIf;
@@ -72,6 +73,11 @@ private boolean isOracle() {
     return JdbcEnv.isOracle();
   }
 
+  @SuppressWarnings("unused")
+  private boolean isSqlServer() {
+    return JdbcEnv.isSqlServer();
+  }
+
   @SuppressWarnings("unused")
   private boolean isDb2() {
     return JdbcEnv.isDb2();
@@ -84,7 +90,7 @@ private boolean isSqlite() {
 
   @SuppressWarnings("unused")
   private boolean isColumnTypeConversionToTextNotFullySupported() {
-    return JdbcEnv.isDb2() || JdbcEnv.isOracle() || JdbcEnv.isSqlite();
+    return JdbcEnv.isDb2() || JdbcEnv.isSqlServer() || JdbcEnv.isOracle() || JdbcEnv.isSqlite();
   }
 
   @SuppressWarnings("unused")
@@ -117,6 +123,54 @@ public void importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationEx
         .alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ForImportedTable_ShouldAlterColumnTypesCorrectly();
   }
 
+  @Test
+  @EnabledIf("isSqlServer")
+  public void
+      alterColumnType_SqlServer_AlterColumnTypeFromEachExistingDataTypeToText_ForImportedTable_ShouldAlterColumnTypesCorrectly()
+          throws Exception {
+    // Arrange
+    testDataList.addAll(createExistingDatabaseWithAllDataTypes());
+    for (TestData testData : testDataList) {
+      if (testData.isImportableTable()) {
+        admin.importTable(
+            getNamespace(),
+            testData.getTableName(),
+            Collections.emptyMap(),
+            testData.getOverrideColumnsType());
+      }
+    }
+
+    for (TestData testData : testDataList) {
+      if (testData.isImportableTable()) {
+        // Act
+        TableMetadata metadata = testData.getTableMetadata();
+        for (String column : metadata.getColumnNames()) {
+          if (!metadata.getPartitionKeyNames().contains(column)
+              && !metadata.getClusteringKeyNames().contains(column)) {
+            if (Objects.equals(column, "col16")) {
+              // Conversion from IMAGE to VARCHAR(8000) is not supported in SQL Server engine
+              continue;
+            }
+            admin.alterColumnType(getNamespace(), testData.getTableName(), column, DataType.TEXT);
+          }
+        }
+
+        // Assert
+        TableMetadata newMetadata = admin.getTableMetadata(getNamespace(), testData.getTableName());
+        assertThat(newMetadata).isNotNull();
+        for (String column : metadata.getColumnNames()) {
+          if (!metadata.getPartitionKeyNames().contains(column)
+              && !metadata.getClusteringKeyNames().contains(column)) {
+            if (metadata.getColumnDataType(column).equals(DataType.BLOB)) {
+              continue;
+            }
+            assertThat(newMetadata.getColumnDataType(column)).isEqualTo(DataType.TEXT);
+          }
+        }
+      }
+    }
+  }
+
   @Test
   @EnabledIf("isDb2")
   public void
@@ -142,7 +196,7 @@ public void importTable_ForUnsupportedDatabase_ShouldThrowUnsupportedOperationEx
           if (!metadata.getPartitionKeyNames().contains(column)
               && !metadata.getClusteringKeyNames().contains(column)) {
             if (metadata.getColumnDataType(column).equals(DataType.BLOB)) {
-              // Conversion from BLOB TO TEXT is not supported in Oracle engine
+              // Conversion from BLOB to TEXT is not supported in Db2 engine
               continue;
             }
             admin.alterColumnType(getNamespace(), testData.getTableName(), column, DataType.TEXT);

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcEnv.java

@@ -58,6 +58,10 @@ public static boolean isOracle() {
     return System.getProperty(PROP_JDBC_URL, DEFAULT_JDBC_URL).startsWith("jdbc:oracle:");
   }
 
+  public static boolean isSqlServer() {
+    return System.getProperty(PROP_JDBC_URL, DEFAULT_JDBC_URL).startsWith("jdbc:sqlserver:");
+  }
+
   public static boolean isSqlite() {
     return System.getProperty(PROP_JDBC_URL, DEFAULT_JDBC_URL).startsWith("jdbc:sqlite:");
   }