Skip to content

Commit 74879fd

Browse files
feeblefakieKodaiD
andauthored
Backport to branch(3) : Add rename table (#3025)
Co-authored-by: Kodai Doki <[email protected]>
1 parent f889e89 commit 74879fd

File tree

45 files changed

+900
-45
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+900
-45
lines changed

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,4 +72,20 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7272
admin.dropTable(getNamespace1(), getTable4(), true);
7373
}
7474
}
75+
76+
@Override
77+
@Disabled("Cassandra does not support renaming tables")
78+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
79+
80+
@Override
81+
@Disabled("Cassandra does not support renaming tables")
82+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
83+
84+
@Override
85+
@Disabled("Cassandra does not support renaming tables")
86+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
87+
88+
@Override
89+
@Disabled("Cassandra does not support renaming tables")
90+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7591
}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminIntegrationTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,20 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7171
admin.dropTable(getNamespace1(), getTable4(), true);
7272
}
7373
}
74+
75+
@Override
76+
@Disabled("Cassandra does not support renaming tables")
77+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
78+
79+
@Override
80+
@Disabled("Cassandra does not support renaming tables")
81+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
82+
83+
@Override
84+
@Disabled("Cassandra does not support renaming tables")
85+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
86+
87+
@Override
88+
@Disabled("Cassandra does not support renaming tables")
89+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7490
}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminPermissionIntegrationTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,4 +153,9 @@ public void renameColumn_WithSufficientPermission_ShouldSucceed() throws Executi
153153
assertThatCode(() -> adminForNormalUser.renameColumn(NAMESPACE, TABLE, COL_NAME1, NEW_COL_NAME))
154154
.doesNotThrowAnyException();
155155
}
156+
157+
@Test
158+
@Override
159+
@Disabled("Cassandra does not support renaming tables")
160+
public void renameTable_WithSufficientPermission_ShouldSucceed() {}
156161
}

core/src/integration-test/java/com/scalar/db/storage/cassandra/ConsensusCommitAdminIntegrationTestWithCassandra.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,20 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
8989
admin.dropTable(namespace1, TABLE4, true);
9090
}
9191
}
92+
93+
@Override
94+
@Disabled("Cassandra does not support renaming tables")
95+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
96+
97+
@Override
98+
@Disabled("Cassandra does not support renaming tables")
99+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
100+
101+
@Override
102+
@Disabled("Cassandra does not support renaming tables")
103+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
104+
105+
@Override
106+
@Disabled("Cassandra does not support renaming tables")
107+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
92108
}

core/src/integration-test/java/com/scalar/db/storage/cassandra/SingleCrudOperationTransactionAdminIntegrationTestWithCassandra.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,20 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7676
admin.dropTable(namespace1, TABLE4, true);
7777
}
7878
}
79+
80+
@Override
81+
@Disabled("Cassandra does not support renaming tables")
82+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
83+
84+
@Override
85+
@Disabled("Cassandra does not support renaming tables")
86+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
87+
88+
@Override
89+
@Disabled("Cassandra does not support renaming tables")
90+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
91+
92+
@Override
93+
@Disabled("Cassandra does not support renaming tables")
94+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7995
}

core/src/integration-test/java/com/scalar/db/storage/cosmos/ConsensusCommitAdminIntegrationTestWithCosmos.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,20 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
8484
@Override
8585
@Disabled("Cosmos DB does not support renaming columns")
8686
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
87+
88+
@Override
89+
@Disabled("Cosmos DB does not support renaming tables")
90+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
91+
92+
@Override
93+
@Disabled("Cosmos DB does not support renaming tables")
94+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
95+
96+
@Override
97+
@Disabled("Cosmos DB does not support renaming tables")
98+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
99+
100+
@Override
101+
@Disabled("Cosmos DB does not support renaming tables")
102+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
87103
}

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,20 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6969
@Override
7070
@Disabled("Cosmos DB does not support renaming columns")
7171
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
72+
73+
@Override
74+
@Disabled("Cosmos DB does not support renaming tables")
75+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
76+
77+
@Override
78+
@Disabled("Cosmos DB does not support renaming tables")
79+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
80+
81+
@Override
82+
@Disabled("Cosmos DB does not support renaming tables")
83+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
84+
85+
@Override
86+
@Disabled("Cosmos DB does not support renaming tables")
87+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7288
}

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,20 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6868
@Override
6969
@Disabled("Cosmos DB does not support renaming columns")
7070
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
71+
72+
@Override
73+
@Disabled("Cosmos DB does not support renaming tables")
74+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
75+
76+
@Override
77+
@Disabled("Cosmos DB does not support renaming tables")
78+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
79+
80+
@Override
81+
@Disabled("Cosmos DB does not support renaming tables")
82+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
83+
84+
@Override
85+
@Disabled("Cosmos DB does not support renaming tables")
86+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7187
}

core/src/integration-test/java/com/scalar/db/storage/cosmos/SingleCrudOperationTransactionAdminIntegrationTestWithCosmos.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,20 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6969
@Override
7070
@Disabled("Cosmos DB does not support renaming columns")
7171
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
72+
73+
@Override
74+
@Disabled("Cosmos DB does not support renaming tables")
75+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
76+
77+
@Override
78+
@Disabled("Cosmos DB does not support renaming tables")
79+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
80+
81+
@Override
82+
@Disabled("Cosmos DB does not support renaming tables")
83+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
84+
85+
@Override
86+
@Disabled("Cosmos DB does not support renaming tables")
87+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
7288
}

core/src/integration-test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,4 +138,20 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
138138
@Override
139139
@Disabled("DynamoDB does not support renaming columns")
140140
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
141+
142+
@Override
143+
@Disabled("DynamoDB does not support renaming tables")
144+
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
145+
146+
@Override
147+
@Disabled("DynamoDB does not support renaming tables")
148+
public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}
149+
150+
@Override
151+
@Disabled("DynamoDB does not support renaming tables")
152+
public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {}
153+
154+
@Override
155+
@Disabled("DynamoDB does not support renaming tables")
156+
public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {}
141157
}

0 commit comments

Comments
 (0)