Merge branch 'master' into improve-logging-in-consensus-commit

Author: brfrn169

.github/workflows/manual-vuln-check.yaml

@@ -10,5 +10,3 @@ jobs:
     uses: ./.github/workflows/vuln-check.yaml
     with:
       target-ref: ${{ github.ref_name }}
-    secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}

.github/workflows/scheduled-vuln-check.yaml

@@ -13,7 +13,6 @@ jobs:
     with:
       target-ref: master
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}
 
   call-vuln-check-for-v3_13:
@@ -22,7 +21,6 @@ jobs:
       target-ref: v3.13
       find-latest-release: true
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}
 
   call-vuln-check-for-v3_14:
@@ -31,7 +29,6 @@ jobs:
       target-ref: v3.14
       find-latest-release: true
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}
 
   call-vuln-check-for-v3_15:
@@ -40,7 +37,6 @@ jobs:
       target-ref: v3.15
       find-latest-release: true
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}
 
   call-vuln-check-for-v3_16:
@@ -49,5 +45,4 @@ jobs:
       target-ref: v3.16
       find-latest-release: true
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}

.github/workflows/vuln-check.yaml

@@ -14,8 +14,6 @@ on:
         type: boolean
         default: false
     secrets:
-      CR_PAT:
-        required: true
       SLACK_SECURITY_WEBHOOK_URL:
         required: false
 
@@ -28,5 +26,4 @@ jobs:
       images: '[["ScalarDB Schema Loader", "scalardb-schema-loader"], ["ScalarDB Data Loader CLI", "scalardb-data-loader-cli"]]'
       version-command: "./gradlew :core:properties -q | grep version: | awk '{print $2}'"
     secrets:
-      CR_PAT: ${{ secrets.CR_PAT }}
       SLACK_SECURITY_WEBHOOK_URL: ${{ secrets.SLACK_SECURITY_WEBHOOK_URL }}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java

@@ -0,0 +1,30 @@
+package com.scalar.db.storage.cassandra;
+
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
+import com.scalar.db.util.AdminTestUtils;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Properties;
+
+public class CassandraAdminCaseSensitivityIntegrationTest
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
+  @Override
+  protected Properties getProperties(String testName) {
+    return CassandraEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return Collections.singletonMap(CassandraAdmin.REPLICATION_FACTOR, "1");
+  }
+
+  @Override
+  protected AdminTestUtils getAdminTestUtils(String testName) {
+    return new CassandraAdminTestUtils(getProperties(testName));
+  }
+
+  @Override
+  protected boolean isTimestampTypeSupported() {
+    return false;
+  }
+}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraCaseSensitivityIntegrationTest.java

@@ -0,0 +1,28 @@
+package com.scalar.db.storage.cassandra;
+
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Properties;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+public class CassandraCaseSensitivityIntegrationTest
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
+  @Override
+  protected Properties getProperties(String testName) {
+    return CassandraEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return Collections.singletonMap(CassandraAdmin.REPLICATION_FACTOR, "1");
+  }
+
+  @Disabled(
+      "In Cassandra, if an IS NULL condition is specified for a column in a non-existing record, "
+          + "the condition is considered satisfied. This behavior differs from that of other adapters")
+  @Override
+  @Test
+  public void put_withPutIfIsNullWhenRecordDoesNotExist_shouldThrowNoMutationException() {}
+}

core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraWithReservedKeywordIntegrationTest.java

@@ -4,6 +4,8 @@
 import java.util.Collections;
 import java.util.Map;
 import java.util.Properties;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
 
 public class CassandraWithReservedKeywordIntegrationTest
     extends DistributedStorageWithReservedKeywordIntegrationTestBase {
@@ -58,4 +60,11 @@ protected String getColumnName5() {
   protected Properties getProperties(String testName) {
     return CassandraEnv.getProperties(testName);
   }
+
+  @Disabled(
+      "In Cassandra, if an IS NULL condition is specified for a column in a non-existing record, "
+          + "the condition is considered satisfied. This behavior differs from that of other adapters")
+  @Override
+  @Test
+  public void put_withPutIfIsNullWhenRecordDoesNotExist_shouldThrowNoMutationException() {}
 }

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java

@@ -0,0 +1,25 @@
+package com.scalar.db.storage.cosmos;
+
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
+import com.scalar.db.util.AdminTestUtils;
+import java.util.Map;
+import java.util.Properties;
+
+public class CosmosAdminCaseSensitivityIntegrationTest
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
+
+  @Override
+  protected Properties getProperties(String testName) {
+    return CosmosEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return CosmosEnv.getCreationOptions();
+  }
+
+  @Override
+  protected AdminTestUtils getAdminTestUtils(String testName) {
+    return new CosmosAdminTestUtils(getProperties(testName));
+  }
+}

core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosCaseSensitivityIntegrationTest.java

@@ -0,0 +1,19 @@
+package com.scalar.db.storage.cosmos;
+
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
+import java.util.Map;
+import java.util.Properties;
+
+public class CosmosCaseSensitivityIntegrationTest
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
+
+  @Override
+  protected Properties getProperties(String testName) {
+    return CosmosEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return CosmosEnv.getCreationOptions();
+  }
+}

core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminCaseSensitivityIntegrationTest.java

@@ -0,0 +1,30 @@
+package com.scalar.db.storage.dynamo;
+
+import com.scalar.db.api.DistributedStorageAdminCaseSensitivityIntegrationTestBase;
+import com.scalar.db.util.AdminTestUtils;
+import java.util.Map;
+import java.util.Properties;
+
+public class DynamoAdminCaseSensitivityIntegrationTest
+    extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
+
+  @Override
+  protected Properties getProperties(String testName) {
+    return DynamoEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return DynamoEnv.getCreationOptions();
+  }
+
+  @Override
+  protected boolean isIndexOnBooleanColumnSupported() {
+    return false;
+  }
+
+  @Override
+  protected AdminTestUtils getAdminTestUtils(String testName) {
+    return new DynamoAdminTestUtils(getProperties(testName));
+  }
+}

core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoCaseSensitivityIntegrationTest.java

@@ -0,0 +1,24 @@
+package com.scalar.db.storage.dynamo;
+
+import com.scalar.db.api.DistributedStorageCaseSensitivityIntegrationTestBase;
+import java.util.Map;
+import java.util.Properties;
+import org.junit.jupiter.api.Disabled;
+
+public class DynamoCaseSensitivityIntegrationTest
+    extends DistributedStorageCaseSensitivityIntegrationTestBase {
+
+  @Override
+  protected Properties getProperties(String testName) {
+    return DynamoEnv.getProperties(testName);
+  }
+
+  @Override
+  protected Map<String, String> getCreationOptions() {
+    return DynamoEnv.getCreationOptions();
+  }
+
+  @Disabled("DynamoDB doesn't support putting a null value for a secondary index column")
+  @Override
+  public void put_PutGivenForIndexedColumnWithNullValue_ShouldPut() {}
+}