Rename isConsistentVirtualTableRead() to isConsistentVirtualTableReadGuaranteed()

Author: brfrn169

core/src/main/java/com/scalar/db/api/StorageInfo.java

@@ -27,7 +27,7 @@ public interface StorageInfo {
    *
    * @return true if the storage guarantees consistent reads for virtual tables, false otherwise
    */
-  boolean isConsistentVirtualTableRead();
+  boolean isConsistentVirtualTableReadGuaranteed();
 
   /**
    * The mutation atomicity unit of the storage.

core/src/main/java/com/scalar/db/common/StorageInfoImpl.java

@@ -11,17 +11,17 @@ public class StorageInfoImpl implements StorageInfo {
   private final String storageName;
   private final MutationAtomicityUnit mutationAtomicityUnit;
   private final int maxAtomicMutationsCount;
-  private final boolean consistentVirtualTableRead;
+  private final boolean consistentVirtualTableReadGuaranteed;
 
   public StorageInfoImpl(
       String storageName,
       MutationAtomicityUnit mutationAtomicityUnit,
       int maxAtomicMutationsCount,
-      boolean consistentVirtualTableRead) {
+      boolean consistentVirtualTableReadGuaranteed) {
     this.storageName = storageName;
     this.mutationAtomicityUnit = mutationAtomicityUnit;
     this.maxAtomicMutationsCount = maxAtomicMutationsCount;
-    this.consistentVirtualTableRead = consistentVirtualTableRead;
+    this.consistentVirtualTableReadGuaranteed = consistentVirtualTableReadGuaranteed;
   }
 
   @Override
@@ -40,8 +40,8 @@ public int getMaxAtomicMutationsCount() {
   }
 
   @Override
-  public boolean isConsistentVirtualTableRead() {
-    return consistentVirtualTableRead;
+  public boolean isConsistentVirtualTableReadGuaranteed() {
+    return consistentVirtualTableReadGuaranteed;
   }
 
   @Override
@@ -56,7 +56,8 @@ public boolean equals(Object o) {
     return getMaxAtomicMutationsCount() == that.getMaxAtomicMutationsCount()
         && Objects.equals(getStorageName(), that.getStorageName())
         && getMutationAtomicityUnit() == that.getMutationAtomicityUnit()
-        && isConsistentVirtualTableRead() == that.isConsistentVirtualTableRead();
+        && isConsistentVirtualTableReadGuaranteed()
+            == that.isConsistentVirtualTableReadGuaranteed();
   }
 
   @Override
@@ -65,7 +66,7 @@ public int hashCode() {
         getStorageName(),
         getMutationAtomicityUnit(),
         getMaxAtomicMutationsCount(),
-        isConsistentVirtualTableRead());
+        isConsistentVirtualTableReadGuaranteed());
   }
 
   @Override
@@ -74,7 +75,7 @@ public String toString() {
         .add("storageName", storageName)
         .add("mutationAtomicityUnit", mutationAtomicityUnit)
         .add("maxAtomicMutationsCount", maxAtomicMutationsCount)
-        .add("consistentVirtualTableRead", consistentVirtualTableRead)
+        .add("consistentVirtualTableReadGuaranteed", consistentVirtualTableReadGuaranteed)
         .toString();
   }
 }

core/src/main/java/com/scalar/db/storage/jdbc/JdbcAdmin.java

@@ -1006,11 +1006,11 @@ public void upgrade(Map<String, String> options) throws ExecutionException {
 
   @Override
   public StorageInfo getStorageInfo(String namespace) throws ExecutionException {
-    boolean consistentVirtualTableRead;
+    boolean consistentVirtualTableReadGuaranteed;
     try (Connection connection = dataSource.getConnection()) {
       int isolationLevel = connection.getTransactionIsolation();
-      consistentVirtualTableRead =
-          isolationLevel >= rdbEngine.getMinimumIsolationLevelForConsistencyReads();
+      consistentVirtualTableReadGuaranteed =
+          isolationLevel >= rdbEngine.getMinimumIsolationLevelForConsistentVirtualTableReads();
     } catch (SQLException e) {
       throw new ExecutionException("Getting the transaction isolation level failed", e);
     }
@@ -1020,7 +1020,7 @@ public StorageInfo getStorageInfo(String namespace) throws ExecutionException {
         StorageInfo.MutationAtomicityUnit.STORAGE,
         // No limit on the number of mutations
         Integer.MAX_VALUE,
-        consistentVirtualTableRead);
+        consistentVirtualTableReadGuaranteed);
   }
 
   @Override

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineDb2.java

@@ -591,7 +591,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In Db2, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistent reads
     return Connection.TRANSACTION_REPEATABLE_READ;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineMysql.java

@@ -511,7 +511,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In MySQL, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistent reads
     return Connection.TRANSACTION_REPEATABLE_READ;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java

@@ -543,7 +543,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In Oracle, only the SERIALIZABLE isolation level guarantees consistent reads
     return Connection.TRANSACTION_SERIALIZABLE;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEnginePostgresql.java

@@ -403,7 +403,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In PostgreSQL, REPEATABLE READ and SERIALIZABLE isolation levels guarantee consistent reads
     return Connection.TRANSACTION_REPEATABLE_READ;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineSqlServer.java

@@ -439,7 +439,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In SQL Server, REPEATABLE READ or higher isolation level guarantees consistent reads
     return Connection.TRANSACTION_REPEATABLE_READ;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineSqlite.java

@@ -391,7 +391,7 @@ public String getTableNamesInNamespaceSql() {
   }
 
   @Override
-  public int getMinimumIsolationLevelForConsistencyReads() {
+  public int getMinimumIsolationLevelForConsistentVirtualTableReads() {
     // In SQLite, READ COMMITTED and higher isolation levels guarantee consistent reads
     return Connection.TRANSACTION_READ_COMMITTED;
   }

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineStrategy.java

@@ -326,5 +326,5 @@ default void throwIfConjunctionsColumnNotSupported(
 
   String getTableNamesInNamespaceSql();
 
-  int getMinimumIsolationLevelForConsistencyReads();
+  int getMinimumIsolationLevelForConsistentVirtualTableReads();
 }