Skip to content

Commit b973df8

Browse files
committed
Feedback changes javadoc and param rename
1 parent e7c68a7 commit b973df8

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

data-loader/core/src/main/java/com/scalar/db/dataloader/core/dataexport/ExportManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
public abstract class ExportManager {
3737
private static final Logger logger = LoggerFactory.getLogger(ExportManager.class);
3838

39-
private final DistributedTransactionManager distributedTransactionManager;
39+
private final DistributedTransactionManager manager;
4040
private final ScalarDbDao dao;
4141
private final ProducerTaskFactory producerTaskFactory;
4242
private final Object lock = new Object();
@@ -89,7 +89,7 @@ public ExportReport startExport(
8989
boolean isJson = exportOptions.getOutputFileFormat() == FileFormat.JSON;
9090

9191
try (TransactionManagerCrudOperable.Scanner scanner =
92-
createScanner(exportOptions, dao, distributedTransactionManager)) {
92+
createScanner(exportOptions, dao, manager)) {
9393

9494
Iterator<Result> iterator = scanner.iterator();
9595
AtomicBoolean isFirstBatch = new AtomicBoolean(true);

data-loader/core/src/main/java/com/scalar/db/dataloader/core/dataimport/dao/ScalarDbDao.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,8 @@ public List<Result> scan(
224224
* Creates a {@link TransactionManagerCrudOperable.Scanner} instance for reading data from
225225
* ScalarDB.
226226
*
227-
* <p>This method builds and executes a {@link Scan} operation for the specified table and returns
228-
* a scanner that iterates over the retrieved records. It operates in storage mode using a {@link
229-
* DistributedTransactionManager}.
227+
* <p>a scanner that iterates over the retrieved records. It performs the scan transactionally
228+
* using a {@link DistributedTransactionManager}.
230229
*
231230
* @param namespace the ScalarDB namespace to scan
232231
* @param table the ScalarDB table name
@@ -258,9 +257,8 @@ public TransactionManagerCrudOperable.Scanner createScanner(
258257
* Creates a {@link TransactionManagerCrudOperable.Scanner} instance for reading data from
259258
* ScalarDB.
260259
*
261-
* <p>This method builds and executes a {@link Scan} operation using the provided parameters and
262-
* returns a scanner that iterates over the matching records. It is used in storage mode through a
263-
* {@link DistributedTransactionManager}.
260+
* <p>returns a scanner that iterates over the matching records. The scan is performed
261+
* transactionally through a {@link DistributedTransactionManager}.
264262
*
265263
* @param namespace the ScalarDB namespace to scan
266264
* @param table the ScalarDB table name

0 commit comments

Comments
 (0)