Skip to content

Commit c044507

Browse files
committed
Resolve conflicts
1 parent 50ec61f commit c044507

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

core/src/main/java/com/scalar/db/storage/objectstorage/cloudstorage/CloudStorageConfig.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.scalar.db.storage.objectstorage.cloudstorage;
22

33
import static com.scalar.db.config.ConfigUtils.getInt;
4+
import static com.scalar.db.config.ConfigUtils.getString;
45

56
import com.google.auth.Credentials;
67
import com.google.auth.oauth2.ServiceAccountCredentials;
@@ -17,6 +18,7 @@
1718
public class CloudStorageConfig implements ObjectStorageConfig {
1819
public static final String STORAGE_NAME = "cloud-storage";
1920
public static final String PREFIX = DatabaseConfig.PREFIX + STORAGE_NAME + ".";
21+
public static final String TABLE_METADATA_NAMESPACE = PREFIX + "table_metadata.namespace";
2022

2123
public static final String PARALLEL_UPLOAD_BLOCK_SIZE_IN_BYTES =
2224
PREFIX + "parallel_upload_block_size_in_bytes";
@@ -40,7 +42,11 @@ public CloudStorageConfig(DatabaseConfig databaseConfig) {
4042
bucket = databaseConfig.getContactPoints().get(0);
4143
projectId = databaseConfig.getUsername().orElse(null);
4244
password = databaseConfig.getPassword().orElse(null);
43-
metadataNamespace = databaseConfig.getSystemNamespaceName();
45+
metadataNamespace =
46+
getString(
47+
databaseConfig.getProperties(),
48+
TABLE_METADATA_NAMESPACE,
49+
DatabaseConfig.DEFAULT_SYSTEM_NAMESPACE_NAME);
4450

4551
if (databaseConfig.getScanFetchSize() != DatabaseConfig.DEFAULT_SCAN_FETCH_SIZE) {
4652
logger.warn(

core/src/test/java/com/scalar/db/storage/objectstorage/cloudstorage/CloudStorageConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void constructor_AllPropertiesGiven_ShouldLoadProperly() {
2424
props.setProperty(DatabaseConfig.USERNAME, ANY_PROJECT_ID);
2525
props.setProperty(DatabaseConfig.PASSWORD, ANY_PASSWORD);
2626
props.setProperty(DatabaseConfig.STORAGE, CloudStorage_STORAGE);
27-
props.setProperty(DatabaseConfig.SYSTEM_NAMESPACE_NAME, ANY_TABLE_METADATA_NAMESPACE);
27+
props.setProperty(CloudStorageConfig.TABLE_METADATA_NAMESPACE, ANY_TABLE_METADATA_NAMESPACE);
2828
props.setProperty(
2929
CloudStorageConfig.PARALLEL_UPLOAD_BLOCK_SIZE_IN_BYTES,
3030
ANY_PARALLEL_UPLOAD_BLOCK_SIZE_IN_BYTES);

0 commit comments

Comments
 (0)