Spotbugs issues fixed

Author: inv-jishnu

data-loader/cli/src/test/java/com/scalar/db/dataloader/cli/command/dataexport/ConsoleExportProgressReporterTest.java

@@ -6,6 +6,7 @@
 
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
+import java.io.UnsupportedEncodingException;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -16,8 +17,8 @@ class ConsoleExportProgressReporterTest {
   private final PrintStream originalOut = System.out;
 
   @BeforeEach
-  void setUpStreams() {
-    System.setOut(new PrintStream(outContent));
+  void setUpStreams() throws UnsupportedEncodingException {
+    System.setOut(new PrintStream(outContent, true, "UTF-8"));
   }
 
   @AfterEach
@@ -26,22 +27,23 @@ void restoreStreams() {
   }
 
   @Test
-  void testStartMessageIncludesExportFilePath() {
+  void testStartMessageIncludesExportFilePath() throws UnsupportedEncodingException {
     new ConsoleExportProgressReporter("output/test.csv");
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
     assertTrue(output.contains("📤 Starting export"), "Expected start message");
     assertTrue(
         output.contains("📁 Exporting data to file: output/test.csv"), "Expected file path info");
   }
 
   @Test
-  void testCompletionMessageIncludesFilePathAndDuration() throws InterruptedException {
+  void testCompletionMessageIncludesFilePathAndDuration()
+      throws InterruptedException, UnsupportedEncodingException {
     ConsoleExportProgressReporter reporter = new ConsoleExportProgressReporter("target/output.csv");
 
     Thread.sleep(100); // Simulate work
 
     reporter.reportCompletion(12345);
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
 
     assertTrue(
         output.contains("✅ Export completed: 12,345 records exported to target/output.csv"),
@@ -50,30 +52,31 @@ void testCompletionMessageIncludesFilePathAndDuration() throws InterruptedExcept
   }
 
   @Test
-  void testCompletionOnlyPrintedOnce() {
+  void testCompletionOnlyPrintedOnce() throws UnsupportedEncodingException {
     ConsoleExportProgressReporter reporter = new ConsoleExportProgressReporter("target/output.csv");
 
     reporter.reportCompletion(100);
     reporter.reportCompletion(999999); // Should be ignored
 
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
     int count = output.split("Export completed").length - 1;
     assertEquals(1, count, "Expected completion to be printed only once");
   }
 
   @Test
-  void testReportError_shouldPrintErrorMessageWithExceptionMessage() {
+  void testReportError_shouldPrintErrorMessageWithExceptionMessage()
+      throws UnsupportedEncodingException {
     ByteArrayOutputStream errContent = new ByteArrayOutputStream();
     PrintStream originalErr = System.err;
-    System.setErr(new PrintStream(errContent));
+    System.setErr(new PrintStream(errContent, true, "UTF-8"));
 
     try {
       String errorMessage = "Something went wrong";
       Throwable cause = new RuntimeException("Test exception");
 
       ConsoleExportProgressReporter.reportError(errorMessage, cause);
 
-      String output = errContent.toString();
+      String output = errContent.toString("UTF-8");
       assertTrue(
           output.contains("❌ Export failed: " + errorMessage), "Expected main error message");
       assertTrue(output.contains("Cause: " + cause.getMessage()), "Expected exception message");
@@ -83,17 +86,18 @@ void testReportError_shouldPrintErrorMessageWithExceptionMessage() {
   }
 
   @Test
-  void testReportError_shouldPrintMessageWithoutExceptionWhenNull() {
+  void testReportError_shouldPrintMessageWithoutExceptionWhenNull()
+      throws UnsupportedEncodingException {
     ByteArrayOutputStream errContent = new ByteArrayOutputStream();
     PrintStream originalErr = System.err;
-    System.setErr(new PrintStream(errContent));
+    System.setErr(new PrintStream(errContent, true, "UTF-8"));
 
     try {
       String errorMessage = "Directory not found";
 
       ConsoleExportProgressReporter.reportError(errorMessage, null);
 
-      String output = errContent.toString();
+      String output = errContent.toString("UTF-8");
       assertTrue(output.contains("❌ Export failed: " + errorMessage), "Expected error message");
       assertFalse(
           output.contains("Cause:"), "Should not print exception cause when throwable is null");

data-loader/cli/src/test/java/com/scalar/db/dataloader/cli/command/dataimport/ConsoleImportProgressListenerTest.java

@@ -10,6 +10,7 @@
 import com.scalar.db.dataloader.core.dataimport.transactionbatch.ImportTransactionBatchStatus;
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
+import java.io.UnsupportedEncodingException;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.Arrays;
@@ -24,8 +25,8 @@ class ConsoleImportProgressListenerTest {
   private ConsoleImportProgressListener listener;
 
   @BeforeEach
-  void setUp() {
-    System.setOut(new PrintStream(outContent));
+  void setUp() throws UnsupportedEncodingException {
+    System.setOut(new PrintStream(outContent, true, "UTF-8"));
     listener = new ConsoleImportProgressListener(Duration.ofMillis(100));
   }
 
@@ -36,7 +37,7 @@ void tearDown() {
 
   @Test
   void testOnDataChunkStartedAndCompleted_shouldTrackSuccessAndFailureCounts()
-      throws InterruptedException {
+      throws InterruptedException, UnsupportedEncodingException {
     int chunkId = 1;
     Instant start = Instant.now();
     TimeUnit.MILLISECONDS.sleep(50);
@@ -75,7 +76,7 @@ void testOnDataChunkStartedAndCompleted_shouldTrackSuccessAndFailureCounts()
     TimeUnit.MILLISECONDS.sleep(200); // Allow render
     listener.onAllDataChunksCompleted();
 
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
 
     assertTrue(output.contains("✓ Chunk 1"), "Expected chunk log line");
     assertTrue(output.contains("90 records imported successfully"), "Expected success count");
@@ -87,7 +88,7 @@ void testOnDataChunkStartedAndCompleted_shouldTrackSuccessAndFailureCounts()
 
   @Test
   void testOnTransactionBatchFailed_shouldAccumulateFailuresInChunkFailureLogs()
-      throws InterruptedException {
+      throws InterruptedException, UnsupportedEncodingException {
     // Arrange: Build dummy failed batch
     ImportTaskResult task =
         ImportTaskResult.builder()
@@ -117,7 +118,7 @@ void testOnTransactionBatchFailed_shouldAccumulateFailuresInChunkFailureLogs()
     TimeUnit.MILLISECONDS.sleep(500);
 
     // Assert
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
     System.out.println("OUTPUT:\n" + output); // Useful for debug
     assertTrue(
         output.contains("❌ Chunk id: 7, Transaction batch id: 2 failed"),
@@ -129,9 +130,10 @@ void testOnTransactionBatchFailed_shouldAccumulateFailuresInChunkFailureLogs()
   }
 
   @Test
-  void testOnAllDataChunksCompleted_shouldShutdownAndPrintFinalSummary() {
+  void testOnAllDataChunksCompleted_shouldShutdownAndPrintFinalSummary()
+      throws UnsupportedEncodingException {
     listener.onAllDataChunksCompleted();
-    String output = outContent.toString();
+    String output = outContent.toString("UTF-8");
     assertTrue(output.contains("✅ Import completed"), "Should print completion summary");
   }