Skip to content

Commit ed4501b

Browse files
KodaiDbrfrn169
andauthored
Apply suggestions from code review
Co-authored-by: Toshihiro Suzuki <[email protected]>
1 parent 16a06bb commit ed4501b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

core/src/main/java/com/scalar/db/storage/jdbc/JdbcAdmin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -890,8 +890,8 @@ public void renameColumn(
890890
throws ExecutionException {
891891
try {
892892
TableMetadata currentTableMetadata = getTableMetadata(namespace, table);
893-
rdbEngine.throwIfRenameColumnNotSupported(oldColumnName, currentTableMetadata);
894893
assert currentTableMetadata != null;
894+
rdbEngine.throwIfRenameColumnNotSupported(oldColumnName, currentTableMetadata);
895895
TableMetadata.Builder tableMetadataBuilder =
896896
TableMetadata.newBuilder(currentTableMetadata).renameColumn(oldColumnName, newColumnName);
897897
if (currentTableMetadata.getPartitionKeyNames().contains(oldColumnName)) {

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ default void throwIfDuplicatedIndexWarning(SQLWarning warning) throws SQLExcepti
273273
}
274274

275275
/**
276-
* Throws an exception if renaming columns is not supported in the underlying database.
276+
* Throws an exception if renaming the column is not supported in the underlying database.
277277
*
278278
* @param columnName the current name of the column to rename
279279
* @param tableMetadata the current table metadata

0 commit comments

Comments
 (0)