Backport to branch(3) : Fix error handling for one-phase commit

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix error handling for one-phase commit #2826
• Backported commit: 7a01959

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a crucial fix that refines the error handling mechanism for one-phase commit operations. The primary goal is to provide more granular and accurate exception types when commit failures occur, specifically reclassifying certain ExecutionExceptions as UnknownTransactionStatusExceptions to better reflect the state of the transaction. This change improves the robustness and clarity of error reporting within the transaction system.

Highlights

• Error Handling Refinement: The onePhaseCommitRecords method in CommitHandler.java has been updated to declare more specific exceptions (CommitConflictException, UnknownTransactionStatusException) in its signature, replacing the more general CommitException.
• Exception Type Change: Within the onePhaseCommitRecords method, ExecutionExceptions caught during the one-phase commit process are now re-thrown as UnknownTransactionStatusExceptions, providing more precise information about the transaction's status when an underlying execution error occurs.
• Test Updates: Corresponding unit tests in CommitHandlerTest.java and CommitHandlerWithGroupCommitTest.java have been updated to reflect these changes, including modifications to method signatures, test names, and expected exception types in assertions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request backports a fix for error handling in one-phase commits, changing the exception type thrown when a storage-level ExecutionException occurs. A potential issue was identified where the code throws UnknownTransactionStatusException even before any data has been written. I've suggested a modification to ensure that a CommitException is thrown when the exception occurs during mutation composition.