Backport to branch(3) : Add validation for secondary indexes in table metadata with Object Storage

[feeblefakie]

This is an automated request for a manual backport of the following:

• Original PR: Add validation for secondary indexes in table metadata with Object Storage #3127
• Commit to backport: ad27355

1. Resolve any conflicts that occur during the cherry-picking process.

git fetch origin &&
git checkout 3-pull-3127 &&
git cherry-pick --no-rerere-autoupdate -m1 ad27355f1211352863772f041485b4c8b1c90b43

2. Push the changes.
3. Merge this PR after all checks have passed.

Thank you!

[KodaiD]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly adds validation to disallow secondary indexes for Object Storage, as it doesn't support them. The core logic is sound, and the integration tests are updated accordingly. The base test classes are also refactored to better support this change. My review includes a couple of suggestions to reduce code duplication in the test files for improved maintainability.

[Copilot]

Pull Request Overview

This pull request removes secondary index support from Object Storage implementation by disallowing tables with secondary indexes to be created or repaired. The change adds validation in ObjectStorageAdmin to reject table metadata containing secondary indexes, since Object Storage doesn't support index functionality.

• Adds checkTableMetadata() validation method to reject tables with secondary indexes
• Updates test base classes to make getTableMetadata() overridable
• Modifies Object Storage-specific tests to override getTableMetadata() and remove secondary indexes

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ObjectStorageAdmin.java	Adds validation method to reject table metadata with secondary indexes in createTable() and repairTable()
DistributedTransactionAdminIntegrationTestBase.java	Makes getTableMetadata() overridable and updates tests to use the overridable method
DistributedStorageAdminIntegrationTestBase.java	Updates tests to use overridable getTableMetadata() for flexibility
DistributedTransactionAdminRepairTableIntegrationTestBase.java	Removes secondary indexes from repair table test metadata
DistributedStorageAdminRepairTableIntegrationTestBase.java	Changes column name visibility and removes secondary indexes from repair table test metadata
SingleCrudOperationTransactionAdminIntegrationTestWithObjectStorage.java	Overrides getTableMetadata() to remove secondary indexes for Object Storage
ObjectStorageAdminIntegrationTest.java	Overrides getTableMetadata() to provide metadata without secondary indexes
ObjectStorageAdminCaseSensitivityIntegrationTest.java	Overrides getTableMetadata() to provide metadata without secondary indexes
ConsensusCommitAdminIntegrationTestWithObjectStorage.java	Overrides getTableMetadata() to remove secondary indexes for Object Storage

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.