Skip to content

Commit 8cc8458

Browse files
committed
Make filter method more concise
1 parent 7e7bcd4 commit 8cc8458

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/main/scala/org/scalatestplus/junit/JUnitRunner.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@ final class JUnitRunner(suiteClass: java.lang.Class[_ <: Suite]) extends org.jun
139139

140140
@throws(classOf[NoTestsRemainException])
141141
override def filter(filter: TestFilter): Unit = {
142-
getDescription.getChildren.asScala
143-
.filter(child => !filter.shouldRun(child))
144-
.foreach(child => excludedTests.add(child.getMethodName))
145-
if (getDescription.getChildren.isEmpty) {
146-
throw new NoTestsRemainException()
147-
}
142+
val children = getDescription.getChildren.asScala
143+
excludedTests ++= children
144+
.filterNot(filter.shouldRun)
145+
.map(_.getMethodName)
146+
147+
if (children.isEmpty) throw new NoTestsRemainException
148148
}
149149

150150
}

0 commit comments

Comments
 (0)