add back comments from initial code

Author: TarunRavikumar

model-engine/model_engine_server/infra/repositories/s3_file_llm_fine_tune_events_repository.py

@@ -29,6 +29,12 @@ def _open(self, uri: str, mode: str = "rt", **kwargs) -> IO:
         return smart_open.open(uri, mode, transport_params=transport_params)
 
     def _get_model_cache_directory_name(self, model_name: str) -> str:
+        """How huggingface maps model names to directory names in their cache for model files.
+        We adopt this when storing model cache files in s3.
+        Args:
+            model_name (str): Name of the huggingface model
+        """
+
         name = "models--" + model_name.replace("/", "--")
         return name
 

model-engine/model_engine_server/infra/repositories/s3_file_llm_fine_tune_repository.py

@@ -22,7 +22,7 @@ def _open(self, uri: str, mode: str = "rt", **kwargs) -> IO:
 
     @staticmethod
     def _get_key(model_name: str, fine_tuning_method: str) -> str:
-        return f"{model_name}-{fine_tuning_method}"
+        return f"{model_name}-{fine_tuning_method}" # possible for collisions but we control these names
 
     async def get_job_template_for_model(
         self, model_name: str, fine_tuning_method: str

pr.md

@@ -0,0 +1,20 @@
+# Add On-Premise Deployment Support
+
+This PR adds comprehensive support for on-premise deployments using Redis, MinIO/S3-compatible storage, and private container registries as alternatives to cloud-managed services.
+
+## Key Changes
+
+- **New on-prem configuration**: Added `onprem.yaml` config file with settings for MinIO, Redis, and private registries
+- **Redis-based infrastructure**: Implemented Redis task queues and on-prem queue endpoint delegate
+- **S3-compatible storage**: Added support for MinIO and custom S3 endpoints with configurable addressing styles
+- **Container registry flexibility**: Support for private registries with `OnPremDockerRepository`
+- **Database configuration**: Environment variable-based PostgreSQL connection for on-prem deployments
+- **Improved logging**: Enhanced error handling and debug logs in S3 file storage gateway
+
+## Configuration Highlights
+
+The on-prem setup allows deployments to use:
+- MinIO or S3-compatible object storage instead of AWS S3/Azure Blob
+- Redis for Celery task queues and caching instead of SQS/ASB
+- Local PostgreSQL with environment-based credentials
+- Private container registries instead of ECR/ACR