Skip to content

Commit 369cb3f

Browse files
authored
include .txt files when downloading model weights from S3 (#711)
* include .txt files * fix test * fix test
1 parent 3aa4a73 commit 369cb3f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ def load_model_weights_sub_commands_s3(
629629
# filter to configs ('*.model' and '*.json') and weights ('*.safetensors')
630630
# For models that are not supported by transformers directly, we need to include '*.py' and '*.bin'
631631
# to load the model. Only set this flag if "trust_remote_code" is set to True
632-
file_selection_str = '--include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --exclude "optimizer*"'
632+
file_selection_str = '--include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --include "*.txt" --exclude "optimizer*"'
633633
if trust_remote_code:
634634
file_selection_str += ' --include "*.py"'
635635
subcommands.append(

model-engine/tests/unit/domain/test_llm_use_cases.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ def test_load_model_weights_sub_commands(
584584
)
585585

586586
expected_result = [
587-
'./s5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --exclude "optimizer*" s3://fake-checkpoint/* test_folder',
587+
'./s5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --include "*.txt" --exclude "optimizer*" s3://fake-checkpoint/* test_folder',
588588
]
589589
assert expected_result == subcommands
590590

@@ -594,7 +594,7 @@ def test_load_model_weights_sub_commands(
594594
)
595595

596596
expected_result = [
597-
'./s5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --exclude "optimizer*" --include "*.py" s3://fake-checkpoint/* test_folder',
597+
'./s5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --include "*.txt" --exclude "optimizer*" --include "*.py" s3://fake-checkpoint/* test_folder',
598598
]
599599
assert expected_result == subcommands
600600

@@ -609,7 +609,7 @@ def test_load_model_weights_sub_commands(
609609

610610
expected_result = [
611611
"s5cmd > /dev/null || conda install -c conda-forge -y s5cmd",
612-
's5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --exclude "optimizer*" s3://fake-checkpoint/* test_folder',
612+
's5cmd --numworkers 512 cp --concurrency 10 --include "*.model" --include "*.model.v*" --include "*.json" --include "*.safetensors" --include "*.txt" --exclude "optimizer*" s3://fake-checkpoint/* test_folder',
613613
]
614614
assert expected_result == subcommands
615615

0 commit comments

Comments
 (0)