Skip to content

Commit f11eb14

Browse files
authored
Increase graceful timeout and hardcode AWS_PROFILE (#306)
1 parent 9b07530 commit f11eb14

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

charts/model-engine/templates/service_template_config_map.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,11 @@ data:
7777
spec:
7878
affinity:
7979
{{- include "modelEngine.serviceTemplateAffinity" . | nindent 12 }}
80+
{{- if eq $mode "async" }}
81+
terminationGracePeriodSeconds: 1800
82+
{{- else }}
8083
terminationGracePeriodSeconds: 600
84+
{{- end }}
8185
{{- if $service_template_service_account_name }}
8286
serviceAccount: {{ $service_template_service_account_name }}
8387
{{- else }}

model-engine/model_engine_server/inference/sync_inference/start_fastapi_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
def start_server():
1212
parser = argparse.ArgumentParser()
13-
parser.add_argument("--graceful-timeout", type=int, default=600)
13+
parser.add_argument("--graceful-timeout", type=int, default=1800)
1414
args, extra_args = parser.parse_known_args()
1515

1616
# TODO: HTTPS

model-engine/model_engine_server/infra/gateways/resources/k8s_resource_types.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -507,6 +507,7 @@ def get_endpoint_resource_arguments_from_request(
507507
main_env = []
508508
if isinstance(flavor, RunnableImageLike) and flavor.env:
509509
main_env = [{"name": key, "value": value} for key, value in flavor.env.items()]
510+
main_env.append({"name": "AWS_PROFILE", "value": build_endpoint_request.aws_role})
510511

511512
infra_service_config_volume_mount_path = "/infra-config"
512513
forwarder_config_file_name = "service--forwarder.yaml"

model-engine/requirements-test.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ pytest-mypy==0.9.1
99
pytest-mypy-plugins==1.10.1
1010
pytest-asyncio==0.20.1
1111
pytest-pylint==0.18.0
12+
pylint<3.0.0
1213
types-cachetools==5.3.0.5
1314
types-croniter==1.4.0.0
1415
types-PyYAML==6.0.7

0 commit comments

Comments
 (0)