Add inline ignores for obvious unused argument cases

- Deprecated functions, framework callbacks, future extension parameters
- Fixed import type checking issue by moving import out of TYPE_CHECKING
- Added noqa comments for legitimate unused parameters

Author: prassanna-ravishankar

LINTING-CALLOUTS.md

@@ -0,0 +1,71 @@
+# Linting Callouts and Remaining Issues
+
+## Summary
+Fixed 213 out of 335 linting issues (63% improvement). Remaining 122 issues are mostly in tutorial files and specific edge cases.
+
+## Questions/Decisions Needed
+
+### 1. Tutorial Print Statements (T201)
+**Status**: Left as-is
+**Issue**: Many tutorial notebooks and example files contain `print()` statements
+**Question**: Should tutorial `print()` statements be left for educational purposes, or converted to logger calls?
+**Files**: All tutorial dev.ipynb files, tutorial project files
+
+### 2. Unused Arguments in Workflow/Activity Functions (ARG001/ARG002)
+**Status**: Partially fixed
+**Issue**: Many temporal workflow and activity functions have unused `context` parameters that are required by the framework
+**Question**: Should these be prefixed with underscore or left as-is since they're part of the temporal interface?
+**Files**:
+- `examples/tutorials/10_agentic/10_temporal/*/project/workflow.py`
+- Various activity and handler functions
+
+### 3. Test File Print Statements
+**Status**: Left as-is
+**Issue**: Test runner and dev tools intentionally use print for user output
+**Files**:
+- `src/agentex/lib/sdk/fastacp/tests/run_tests.py`
+- `src/agentex/lib/utils/dev_tools/async_messages.py`
+
+### 4. Debug Template Import Error Setup
+**Status**: Left error print statements
+**Issue**: Debug setup in templates still uses print() for error cases (ImportError, Exception)
+**Question**: Should error messages stay as print() to ensure they're visible even if logging isn't set up?
+
+## Remaining Issues by Category
+
+### Print Statements (T201) - 85 issues
+- **Tutorial notebooks**: 67 issues across example/tutorial dev.ipynb files
+- **Test/Dev tools**: 15 issues in test runners and dev utilities
+- **Template error handling**: 3 issues in Jinja template error cases
+
+### Unused Arguments (ARG*) - 36 issues
+- **Temporal workflows**: Required by framework but unused
+- **Test fixtures**: Standard pytest/test patterns
+- **CLI init functions**: Legacy parameters
+- **Lambda functions**: Anonymous function parameters
+
+### Import Issues (I001, F401, TC004) - 1 issue
+- **Type checking import**: One import used outside type checking block
+
+## Fixed Issues (213 total)
+- ✅ Import sorting (I001): 190+ issues
+- ✅ Unused imports (F401): Multiple files
+- ✅ Exception handling (B904): Added proper exception chaining
+- ✅ Return in finally (B012): Restructured exception handling
+- ✅ Bare except (E722): Specified Exception type
+- ✅ Blind exception assert (B017): Specified exact exception types
+- ✅ Core library print statements: Converted to logger calls
+- ✅ Template print statements: Fixed debug logging in Jinja templates
+
+## Recommendations for PR Discussion
+
+1. **Tutorial Policy**: Establish whether tutorials should use print() or logger
+2. **Framework Interface**: Decide on unused parameter naming for temporal/framework interfaces
+3. **Test Output**: Confirm test runners should keep print() for user visibility
+4. **Error Handling**: Review if debug setup errors should remain as print() statements
+
+## Files with Significant Remaining Issues
+- Tutorial notebooks: All dev.ipynb files (print statements)
+- `examples/tutorials/10_agentic/00_base/090_multi_agent_non_temporal/project/state_machines/content_workflow.py` (8 unused arguments)
+- `examples/tutorials/10_agentic/10_temporal/050_agent_chat_guardrails/project/workflow.py` (10 unused arguments)
+- Various test files (unused test fixture parameters)

examples/tutorials/10_agentic/00_base/080_batch_events/dev.ipynb

@@ -50,7 +50,56 @@
    "id": "3",
    "metadata": {},
    "outputs": [],
-   "source": "from agentex.lib.utils.dev_tools import subscribe_to_async_task_messages\nfrom agentex.types import Event\nfrom agentex.types.agent_rpc_params import ParamsSendEventRequest\n\n# The response is expected to be a list of TaskMessage objects, which is a union of the following types:\n# - TextContent: A message with just text content   \n# - DataContent: A message with JSON-serializable data content\n# - ToolRequestContent: A message with a tool request, which contains a JSON-serializable request to call a tool\n# - ToolResponseContent: A message with a tool response, which contains response object from a tool call in its content\n\n# When processing the message/send response, if you are expecting more than TextContent, such as DataContent, ToolRequestContent, or ToolResponseContent, you can process them as well\n\nconcurrent_event_messages: list[ParamsSendEventRequest] = [\n    {\n        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Hello, what can you do?\"},\n        \"task_id\": task.id,\n    },\n    {\n        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Can you tell me a joke?\"},\n        \"task_id\": task.id,\n    },\n    {\n        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"What is the capital of France?\"},\n        \"task_id\": task.id,\n    },\n    {\n        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Write a short story about a cat\"},\n        \"task_id\": task.id,\n    },\n    {\n        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Tell me how an LLM works\"},\n        \"task_id\": task.id,\n    },\n]\n\nevents: list[Event] = []\n\nfor event_message in concurrent_event_messages:\n    rpc_response = client.agents.send_event(\n        agent_name=AGENT_NAME,\n        params=event_message\n    )\n\n    event = rpc_response.result\n    events.append(event)\n\nfor event in events:\n    print(event)"
+   "source": [
+    "from agentex.types import Event\n",
+    "from agentex.lib.utils.dev_tools import subscribe_to_async_task_messages\n",
+    "from agentex.types.agent_rpc_params import ParamsSendEventRequest\n",
+    "\n",
+    "# The response is expected to be a list of TaskMessage objects, which is a union of the following types:\n",
+    "# - TextContent: A message with just text content   \n",
+    "# - DataContent: A message with JSON-serializable data content\n",
+    "# - ToolRequestContent: A message with a tool request, which contains a JSON-serializable request to call a tool\n",
+    "# - ToolResponseContent: A message with a tool response, which contains response object from a tool call in its content\n",
+    "\n",
+    "# When processing the message/send response, if you are expecting more than TextContent, such as DataContent, ToolRequestContent, or ToolResponseContent, you can process them as well\n",
+    "\n",
+    "concurrent_event_messages: list[ParamsSendEventRequest] = [\n",
+    "    {\n",
+    "        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Hello, what can you do?\"},\n",
+    "        \"task_id\": task.id,\n",
+    "    },\n",
+    "    {\n",
+    "        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Can you tell me a joke?\"},\n",
+    "        \"task_id\": task.id,\n",
+    "    },\n",
+    "    {\n",
+    "        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"What is the capital of France?\"},\n",
+    "        \"task_id\": task.id,\n",
+    "    },\n",
+    "    {\n",
+    "        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Write a short story about a cat\"},\n",
+    "        \"task_id\": task.id,\n",
+    "    },\n",
+    "    {\n",
+    "        \"content\": {\"type\": \"text\", \"author\": \"user\", \"content\": \"Tell me how an LLM works\"},\n",
+    "        \"task_id\": task.id,\n",
+    "    },\n",
+    "]\n",
+    "\n",
+    "events: list[Event] = []\n",
+    "\n",
+    "for event_message in concurrent_event_messages:\n",
+    "    rpc_response = client.agents.send_event(\n",
+    "        agent_name=AGENT_NAME,\n",
+    "        params=event_message\n",
+    "    )\n",
+    "\n",
+    "    event = rpc_response.result\n",
+    "    events.append(event)\n",
+    "\n",
+    "for event in events:\n",
+    "    print(event)"
+   ]
   },
   {
    "cell_type": "code",

src/agentex/lib/cli/commands/init.py

@@ -86,7 +86,7 @@ def create_project_structure(
     console.print(f"\n[green]✓[/green] Created project structure at: {project_dir}")
 
 
-def get_project_context(answers: Dict[str, Any], project_path: Path, manifest_root: Path) -> Dict[str, Any]:
+def get_project_context(answers: Dict[str, Any], project_path: Path, manifest_root: Path) -> Dict[str, Any]:  # noqa: ARG001
     """Get the project context from user answers"""
     # Use agent_directory_name as project_name
     project_name = answers["agent_directory_name"].replace("-", "_")

src/agentex/lib/cli/debug/debug_handlers.py

@@ -9,10 +9,11 @@
 from typing import TYPE_CHECKING, Dict
 from pathlib import Path
 
+import asyncio.subprocess
 from rich.console import Console
 
 if TYPE_CHECKING:
-    import asyncio.subprocess
+    pass
 
 from agentex.lib.utils.logging import make_logger
 

src/agentex/lib/cli/utils/auth_utils.py

@@ -8,7 +8,7 @@
 
 # DEPRECATED: Old function for backward compatibility
 # Will be removed in future version
-def _encode_principal_context(manifest: AgentManifest) -> str | None:
+def _encode_principal_context(manifest: AgentManifest) -> str | None:  # noqa: ARG001
     """
     DEPRECATED: This function is deprecated as AgentManifest no longer contains auth.
     Use _encode_principal_context_from_env_config instead.

src/agentex/lib/core/temporal/activities/__init__.py

@@ -1,7 +1,7 @@
 import httpx
 from scale_gp import SGPClient, SGPClientError
 
-from agentex import AsyncAgentex
+from agentex import AsyncAgentex  # noqa: F401
 from agentex.lib.core.tracing import AsyncTracer
 from agentex.lib.core.services.adk.state import StateService
 from agentex.lib.core.services.adk.tasks import TasksService

src/agentex/lib/core/tracing/processors/agentex_tracing_processor.py

@@ -11,7 +11,7 @@
 
 
 class AgentexSyncTracingProcessor(SyncTracingProcessor):
-    def __init__(self, config: AgentexTracingProcessorConfig):
+    def __init__(self, config: AgentexTracingProcessorConfig):  # noqa: ARG002
         self.client = Agentex()
 
     @override
@@ -65,7 +65,7 @@ def shutdown(self) -> None:
 
 
 class AgentexAsyncTracingProcessor(AsyncTracingProcessor):
-    def __init__(self, config: AgentexTracingProcessorConfig):
+    def __init__(self, config: AgentexTracingProcessorConfig):  # noqa: ARG002
         self.client = create_async_agentex_client()
 
     @override

src/agentex/lib/sdk/fastacp/base/base_acp_server.py

@@ -73,7 +73,7 @@ def _setup_handlers(self):
 
     def get_lifespan_function(self):
         @asynccontextmanager
-        async def lifespan_context(app: FastAPI):
+        async def lifespan_context(app: FastAPI):  # noqa: ARG001
             env_vars = EnvironmentVariables.refresh()
             if env_vars.AGENTEX_BASE_URL:
                 await register_agent(env_vars)

src/agentex/lib/sdk/fastacp/fastacp.py

@@ -33,7 +33,7 @@ class FastACP:
 
     @staticmethod
     # Note: the config is optional and not used right now but is there to be extended in the future
-    def create_sync_acp(config: SyncACPConfig | None = None, **kwargs) -> SyncACP:
+    def create_sync_acp(config: SyncACPConfig | None = None, **kwargs) -> SyncACP:  # noqa: ARG004
         """Create a SyncACP instance"""
         return SyncACP.create(**kwargs)