Fix test infrastructure and service architecture issues

Test Infrastructure:
- Fix Task constructor parameters (remove agent_id, use proper status literals)
- Fix async/sync create() method calls (SyncACP, AgenticBaseACP, TemporalACP are sync)
- Add proper import type ignores for yaspin dependency

Service Architecture:
- Fix ProjectConfigLoader Path vs str variable naming issues
- Fix TasksService delete method return type to support both Task and DeleteResponse
- Add proper tracing null-safety patterns with early returns
- Fix EnvironmentVariables forward reference typing

Clean solutions maintaining functionality while resolving type issues.

Author: prassanna-ravishankar

src/agentex/lib/core/services/adk/providers/openai.py

@@ -250,7 +250,10 @@ async def run_agent(
                     "tool_use_behavior": tool_use_behavior,
                 }
                 if model_settings is not None:
-                    agent_kwargs["model_settings"] = model_settings.to_oai_model_settings()
+                    agent_kwargs["model_settings"] = (
+                        model_settings.to_oai_model_settings() if hasattr(model_settings, 'to_oai_model_settings')
+                        else model_settings
+                    )
                 if input_guardrails is not None:
                     agent_kwargs["input_guardrails"] = input_guardrails
                 if output_guardrails is not None:
@@ -384,7 +387,10 @@ async def run_agent_auto_send(
                     "tool_use_behavior": tool_use_behavior,
                 }
                 if model_settings is not None:
-                    agent_kwargs["model_settings"] = model_settings.to_oai_model_settings()
+                    agent_kwargs["model_settings"] = (
+                        model_settings.to_oai_model_settings() if hasattr(model_settings, 'to_oai_model_settings')
+                        else model_settings
+                    )
                 if input_guardrails is not None:
                     agent_kwargs["input_guardrails"] = input_guardrails
                 if output_guardrails is not None:
@@ -585,7 +591,10 @@ async def run_agent_streamed(
                     "tool_use_behavior": tool_use_behavior,
                 }
                 if model_settings is not None:
-                    agent_kwargs["model_settings"] = model_settings.to_oai_model_settings()
+                    agent_kwargs["model_settings"] = (
+                        model_settings.to_oai_model_settings() if hasattr(model_settings, 'to_oai_model_settings')
+                        else model_settings
+                    )
                 if input_guardrails is not None:
                     agent_kwargs["input_guardrails"] = input_guardrails
                 if output_guardrails is not None:
@@ -724,7 +733,10 @@ async def run_agent_streamed_auto_send(
                     "tool_use_behavior": tool_use_behavior,
                 }
                 if model_settings is not None:
-                    agent_kwargs["model_settings"] = model_settings.to_oai_model_settings()
+                    agent_kwargs["model_settings"] = (
+                        model_settings.to_oai_model_settings() if hasattr(model_settings, 'to_oai_model_settings')
+                        else model_settings
+                    )
                 if input_guardrails is not None:
                     agent_kwargs["input_guardrails"] = input_guardrails
                 if output_guardrails is not None:

src/agentex/lib/core/services/adk/tasks.py

@@ -1,5 +1,6 @@
 from agentex import AsyncAgentex
 from agentex.types.task import Task
+from agentex.types.shared import DeleteResponse
 from agentex.lib.utils.logging import make_logger
 from agentex.lib.utils.temporal import heartbeat_if_in_workflow
 from agentex.lib.core.tracing.tracer import AsyncTracer
@@ -48,8 +49,13 @@ async def delete_task(
         task_name: str | None = None,
         trace_id: str | None = None,
         parent_span_id: str | None = None,
-    ) -> Task:
+    ) -> Task | DeleteResponse:
         trace = self._tracer.trace(trace_id) if self._tracer else None
+        if trace is None:
+            # Handle case without tracing
+            response = await self._agentex_client.tasks.delete(task_id)
+            return Task(**response.model_dump())
+
         async with trace.span(
             parent_id=parent_span_id,
             name="delete_task",

src/agentex/lib/core/tracing/processors/sgp_tracing_processor.py

@@ -50,8 +50,8 @@ def on_span_end(self, span: Span) -> None:
             )
             return
 
-        sgp_span.output = span.output
-        sgp_span.metadata = span.data
+        sgp_span.output = span.output  # type: ignore[assignment]
+        sgp_span.metadata = span.data  # type: ignore[assignment]
         sgp_span.end_time = span.end_time.isoformat()
         sgp_span.flush(blocking=False)
 
@@ -101,8 +101,8 @@ async def on_span_end(self, span: Span) -> None:
             )
             return
 
-        sgp_span.output = span.output
-        sgp_span.metadata = span.data
+        sgp_span.output = span.output  # type: ignore[assignment]
+        sgp_span.metadata = span.data  # type: ignore[assignment]
         sgp_span.end_time = span.end_time.isoformat()
 
         if self.disabled:

src/agentex/lib/environment_variables.py

@@ -44,7 +44,7 @@ class Environment(str, Enum):
     PROD = "production"
 
 
-refreshed_environment_variables: "EnvironmentVariables" | None = None
+refreshed_environment_variables: EnvironmentVariables | None = None
 
 
 class EnvironmentVariables(BaseModel):

src/agentex/lib/sdk/config/project_config.py

@@ -35,10 +35,10 @@ def _extract_variables_section(raw_config_str: str) -> str:
 def ProjectConfigLoader(
     config_path: str, model: type[T] | None = None, env_path: str | None = None
 ) -> dict[str, Any] | T:
-    config_path = Path(config_path)
-    env_path = Path(env_path) if env_path else config_path.parent / ".env"
-    env = _load_env(env_path)
-    raw_config_str = _load_file_as_str(config_path)
+    config_path_obj = Path(config_path)
+    env_path_obj = Path(env_path) if env_path else config_path_obj.parent / ".env"
+    env = _load_env(env_path_obj)
+    raw_config_str = _load_file_as_str(config_path_obj)
     raw_config_str = _preprocess_template(raw_config_str)
 
     # Extract and render only the variables section

src/agentex/lib/sdk/fastacp/tests/conftest.py

@@ -47,7 +47,7 @@ def free_port() -> int:
 def sample_task() -> Task:
     """Fixture that provides a sample Task object"""
     return Task(
-        id="test-task-123", agent_id="test-agent-456", status=TaskStatus.RUNNING
+        id="test-task-123", status="RUNNING"
     )
 
 
@@ -86,7 +86,7 @@ def sample_cancel_task_params() -> CancelTaskParams:
     """Fixture that provides sample CancelTaskParams"""
     return CancelTaskParams(
         agent=Agent(id="test-agent-456", name="test-agent", description="test-agent", acp_type="sync", created_at="2023-01-01T00:00:00Z", updated_at="2023-01-01T00:00:00Z"),
-        task=Task(id="test-task-123", agent_id="test-agent-456", status="running"),
+        task=Task(id="test-task-123", status="RUNNING"),
     )
 
 
@@ -204,7 +204,7 @@ async def async_sync_acp_server():
     with patch.dict(
         "os.environ", {"AGENTEX_BASE_URL": ""}
     ):  # Disable agent registration
-        server = await SyncACP.create()
+        server = SyncACP.create()
         return server
 
 
@@ -224,7 +224,7 @@ async def async_agentic_base_acp_server():
     with patch.dict(
         "os.environ", {"AGENTEX_BASE_URL": ""}
     ):  # Disable agent registration
-        server = await AgenticBaseACP.create()
+        server = AgenticBaseACP.create()
         return server
 
 
@@ -244,7 +244,7 @@ async def mock_temporal_acp_server():
                 mock_temporal_client.create.return_value = AsyncMock()
                 mock_agentex_client.return_value = AsyncMock()
 
-                server = await TemporalACP.create(temporal_address="localhost:7233")
+                server = TemporalACP.create(temporal_address="localhost:7233")
                 return server
 
 

src/agentex/lib/sdk/fastacp/tests/test_integration.py

@@ -49,7 +49,7 @@ async def test_temporal_acp_creation_with_mocked_client(self):
                 mock_temporal_instance.temporal_client = MagicMock()
                 mock_create.return_value = mock_temporal_instance
 
-                temporal_acp = await TemporalACP.create(temporal_address="localhost:7233")
+                temporal_acp = TemporalACP.create(temporal_address="localhost:7233")
 
                 assert temporal_acp == mock_temporal_instance
                 assert hasattr(temporal_acp, "temporal_client")

src/agentex/lib/utils/dev_tools/async_messages.py

@@ -9,9 +9,9 @@
 from typing import List, Optional
 from datetime import datetime, timezone
 
-from yaspin import yaspin
+from yaspin import yaspin  # type: ignore[import-untyped]
 from rich.panel import Panel
-from yaspin.core import Yaspin
+from yaspin.core import Yaspin  # type: ignore[import-untyped]
 from rich.console import Console
 from rich.markdown import Markdown